Update base images #480
Merged
Update base images #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szh
reviewed
Jul 12, 2022
| @@ -1,4 +1,4 @@ | |||
| FROM ruby:3.0 | |||
| FROM ruby:3.1-slim-bullseye | |||
There was a problem hiding this comment.
Is the slim image going to be enough for this?
There was a problem hiding this comment.
Come to think of it, is this even used anywhere?
There was a problem hiding this comment.
First step was to build and get obvious failures to see if slim would be enough. But, no, I don't see it used anywhere... Looks like the main Dockerfile makes a builder now instead of using the Dockerfile.builder. I'll try removing it.
There was a problem hiding this comment.
Do you think we can just remove the whole 'test_app_summon' folder?
szh
reviewed
Jul 12, 2022
Signed-off-by: Andy Tinkham <[email protected]>
andytinkham
force-pushed
the
update-docker-files
branch
from
1af51df to
8db0890
Compare
Signed-off-by: Andy Tinkham <[email protected]>
andytinkham
force-pushed
the
update-docker-files
branch
from
dddac41 to
884685e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andy Tinkham [email protected]
Desired Outcome
Updates test-workflow/test-app-summon/Dockerfile.builder and dev/Dockerfile.debug to later base images.