-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added checks for missing fields in Golden ConfigMap #447
Conversation
394014f
to
9458229
Compare
Can you run the jwt automation scripts and insure this checks not making them fail? |
Will do. Here's the test run: And here are the diffs used to run this test: |
The scripts are not yet for jenkins but currently only for local kind cluster i meant running them localy |
Ah, thanks for the heads up on that. |
@tzheleznyak I ran the E2E scripts locally with all 3 JWT integrations with this change, and all 3 integrations worked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
9458229
to
f128f7d
Compare
Desired Outcome
The Namespace Prep Helm chart fails and emits a clear error message whenever expected fields are missing in the Golden ConfigMap.
Implemented Changes
Added calls to
required
when fields are read from the Golden ConfigMap.Connected Issue/Story
N/A
Definition of Done
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
README
s) were updated in this PRBehavior
Security