Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added checks for missing fields in Golden ConfigMap #447

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

diverdane
Copy link
Contributor

@diverdane diverdane commented Jan 28, 2022

Desired Outcome

The Namespace Prep Helm chart fails and emits a clear error message whenever expected fields are missing in the Golden ConfigMap.

Implemented Changes

Added calls to required when fields are read from the Golden ConfigMap.

Connected Issue/Story

N/A

Definition of Done

  • Helm unittest passes for Namespace Prep Helm chart

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@diverdane diverdane requested a review from a team as a code owner January 28, 2022 21:56
@diverdane diverdane self-assigned this Jan 28, 2022
@diverdane diverdane force-pushed the check-missing-golden-cm-fields branch 6 times, most recently from 394014f to 9458229 Compare January 28, 2022 22:36
@tzheleznyak
Copy link
Contributor

Can you run the jwt automation scripts and insure this checks not making them fail?

@diverdane
Copy link
Contributor Author

diverdane commented Jan 31, 2022

Can you run the jwt automation scripts and insure this checks not making them fail?

Will do. Here's the test run:
https://jenkins.conjur.net/blue/organizations/jenkins/cyberark--conjur-authn-k8s-client/detail/test-with-jwt/1/pipeline

And here are the diffs used to run this test:
https://github.com/cyberark/conjur-authn-k8s-client/compare/test-with-jwt?expand=1

@tzheleznyak
Copy link
Contributor

Can you run the jwt automation scripts and insure this checks not making them fail?

Will do. Here's the test run: https://jenkins.conjur.net/blue/organizations/jenkins/cyberark--conjur-authn-k8s-client/detail/test-with-jwt/1/pipeline

And here are the diffs used to run this test: https://github.com/cyberark/conjur-authn-k8s-client/compare/test-with-jwt?expand=1

The scripts are not yet for jenkins but currently only for local kind cluster i meant running them localy

@diverdane
Copy link
Contributor Author

The scripts are not yet for jenkins but currently only for local kind cluster i meant running them localy

Ah, thanks for the heads up on that.
I ran the scripts locally with this change, and all 3 JWT integrations passed.

@diverdane
Copy link
Contributor Author

@tzheleznyak I ran the E2E scripts locally with all 3 JWT integrations with this change, and all 3 integrations worked.
Are you okay with this change?

szh
szh previously approved these changes Feb 4, 2022
Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants