Log the master IPS when there is a login in error #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzheleznyak
reviewed
Jan 14, 2022
| ips, lookUpError := net.LookupIP(host) | ||
| if lookUpError != nil { | ||
| fmt.Fprintf(os.Stderr, "Could not get IPs: %v\n", lookUpError) | ||
| os.Exit(1) |
There was a problem hiding this comment.
Dont we want to return error if error happens and dont exit here like other places in this file?
tzheleznyak
reviewed
Jan 14, 2022
| fmt.Fprintf(os.Stderr, "Could not get IPs: %v\n", lookUpError) | ||
| os.Exit(1) | ||
| } | ||
| ipsList := " IP Addresses: " |
There was a problem hiding this comment.
There is a join function of any other allegant string function that can do what you doing here
tzheleznyak
reviewed
Jan 14, 2022
| } | ||
| ipsList := " IP Addresses: " | ||
| for _, ip := range ips { | ||
| ipsList += ip.String() |
There was a problem hiding this comment.
If you remain in this way maybe this two lines can be combined to one with string formatting
There was a problem hiding this comment.
i dont think there is a way since the ip address are []byte and have to be first converted to a readable string. i could drop the optional ipv6 and just only submit one ip address, this would get rid of the need of a for loop and also allow me to do a formatted string.
mFelgate
force-pushed
the
Add-IPS-log
branch
2 times, most recently
from
56dd870 to
4cfb2bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
Log the requests IP address when there is a login error
Implemented Changes
Add a function to find and print he ip address taken from the host name.
Connected Issue/Story
CyberArk internal issue link: ONYX-14476
Definition of Done
Improved error message in authenticator client when request goes to an unhealthy master (502 error code doesn't reveal what IP address the name resolved to). Log the node's IP address when the connection fails.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security