Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe personas for E2E Workflow Scripts #418

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Conversation

szh
Copy link
Contributor

@szh szh commented Nov 9, 2021

Desired Outcome

Update the quick start guide in the README here (https://github.com/cyberark/conjur-authn-k8s-client/tree/master/bin/test-workflow) to describe which personas are running which set of scripts according to the personas outlined here (https://github.com/cyberark/dap-wiki/tree/master/how-to-guides/kubernetes).

Personas:

  • k8s cluster admin
  • Conjur admin
  • App developer / devops engineer

Implemented Changes

Connected Issue/Story

Resolves #323

CyberArk internal issue link: ONYX-12652

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@szh szh requested a review from john-odonnell November 9, 2021 20:29
@szh szh self-assigned this Nov 9, 2021
@szh szh requested review from a team as code owners November 9, 2021 20:29
Copy link
Contributor

@john-odonnell john-odonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@szh szh merged commit c48012a into master Nov 10, 2021
@szh szh deleted the ONYX-12652-describe-personas branch November 10, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

E2E Workflow Scripts: Scripts should be split to accommodate personas
2 participants