Updates the app deployment for Openshift #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpothier
force-pushed
the
346-app-deploy-on-openshift
branch
5 times, most recently
from
62c5f8d to
52180f0
Compare
diverdane
reviewed
Aug 13, 2021
| --set postgresqlPassword="$SAMPLE_APP_BACKEND_DB_PASSWORD") | ||
|
|
||
| if [[ "$PLATFORM" == "openshift" ]]; then | ||
| args+=(--set containerSecurityContext.enabled=false \ |
There was a problem hiding this comment.
Nice work figuring out how to get the persistence working on OpenShift!!!
It might help other readers to add a comment pointing to the Bitnami doc for this (just above the conditional two lines up???):
https://github.com/bitnami/charts/tree/master/bitnami/postgresql#differences-between-bitnami-postgresql-image-and-docker-official-image
rpothier
force-pushed
the
346-app-deploy-on-openshift
branch
4 times, most recently
from
5f14683 to
0529758
Compare
rpothier
force-pushed
the
346-app-deploy-on-openshift
branch
from
0529758 to
d014d06
Compare
diverdane
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This updates the test-workflow scripts for use on Openshift.
Also required for this is a change in conjur-oss-helm-chart
What ticket does this PR close?
Resolves #346
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, orManual tests
If you are preparing for a release, have you run the following manual tests to verify existing functionality continues to function as expected?