Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix printing of user to logs #126

Open
sgnn7 opened this issue May 1, 2020 · 0 comments
Open

Fix printing of user to logs #126

sgnn7 opened this issue May 1, 2020 · 0 comments
Labels
component/k8s kind/bug kind/cleanup kind/quality

Comments

@sgnn7
Copy link
Contributor

sgnn7 commented May 1, 2020

Summary

Changing the user from a simple string to a struct broke formatting for all logging of this field in both this project and others that use it.

Steps to Reproduce

Use the project normally and notice the following in logs:

Expected Results

INFO: 2020/04/20 08:23:44 authenticator.go:113: CAKC007I Logging in as user host/conjur/authn-k8s/conjur-5-e799170e-f-test/apps/test-app-5-e799170e-f/service_account/oc-test-app-summon-init.

Actual Results (including error logs, if applicable)

INFO: 2020/04/20 08:23:44 authenticator.go:113: CAKC007I Logging in as user &{host/conjur/authn-k8s/conjur-5-e799170e-f-test/apps/test-app-5-e799170e-f/service_account/oc-test-app-summon-init host.conjur.authn-k8s.conjur-5-e799170e-f-test.apps test-app-5-e799170e-f.service_account.oc-test-app-summon-init}.
@sgnn7 sgnn7 mentioned this issue May 1, 2020
Merged
7 tasks
orenbm added a commit that referenced this issue Sep 13, 2020
@orenbm
Bump version to 0.18.1
aaef963 
### Fixed
- Logs now correctly print only the Conjur identity without the policy branch prefix.
  ([#126](#126))
- When authentication fails, the exponential backoff retry is correctly reset so
  that it will continue to attempt to authenticate until backoff is exhausted.
  ([#158](#158))

### Changed
- Wait slightly for the client certificate file to exist after login before
  raising an error.
  [#119](#119)
@orenbm orenbm mentioned this issue Sep 13, 2020
Merged
orenbm added a commit that referenced this issue Sep 13, 2020
@orenbm
Bump version to 0.18.1
50669bf 
### Fixed
- Logs now correctly print only the Conjur identity without the policy branch prefix.
  ([#126](#126))
- When authentication fails, the exponential backoff retry is correctly reset so
  that it will continue to attempt to authenticate until backoff is exhausted.
  ([#158](#158))

### Changed
- Wait slightly for the client certificate file to exist after login before
  raising an error.
  [#119](#119)
orenbm added a commit that referenced this issue Sep 13, 2020
@orenbm
Bump version to 0.18.1 (#163)
e58708b 
### Fixed
- Logs now correctly print only the Conjur identity without the policy branch prefix.
  ([#126](#126))
- When authentication fails, the exponential backoff retry is correctly reset so
  that it will continue to attempt to authenticate until backoff is exhausted.
  ([#158](#158))

### Changed
- Wait slightly for the client certificate file to exist after login before
  raising an error.
  [#119](#119)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/k8s kind/bug kind/cleanup kind/quality
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgnn7