Implements 'check' command in API #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gl-johnson
suggested changes
Aug 8, 2022
There was a problem hiding this comment.
Added a couple inline comments. In addition you would need to add the following:
- Update the README and CHANGELOG with your additions
- Add unit test(s) to verify that check_privilege is hitting the Conjur API as expected. Check the CONTRIBUTING docs in this repo for more info on running tests locally.
- In your cyberark-conjur-cli PR, add integration tests which validate the behavior of this branch.
Also feel free to reference similar PRs which have gone in recently.
resource_exists
role_memberships
juniortaeza
commented
Aug 8, 2022
| .DS_Store |
There was a problem hiding this comment.
retained .gitignore updates
juniortaeza
commented
Aug 8, 2022
| @@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
| ## [8.0.0] - 2022-05-25 | |||
|
|
|||
| ### Added | |||
| - Add support for Check Privilege endpoint | |||
| [conjur-api-python#34](https://github.com/cyberark/conjur-api-python/pull/34) | |||
There was a problem hiding this comment.
updated CHANGELOG.md with my additions
juniortaeza
commented
Aug 8, 2022
juniortaeza
commented
Aug 8, 2022
conjur_api/http/api.py
Outdated
| @@ -182,8 +182,9 @@ async def check_privilege(self, kind: str, resource_id: str, privilege: str, rol | |||
| if err.status == 404: | |||
| return False | |||
|
|
|||
| return True | |||
| raise | |||
There was a problem hiding this comment.
added the raise to handle other error codes
juniortaeza
commented
Aug 8, 2022
juniortaeza
commented
Aug 8, 2022
juniortaeza
force-pushed
the
check-command-branch
branch
from
6e11904 to
95ebbcd
Compare
juniortaeza
changed the title
juniortaeza
force-pushed
the
check-command-branch
branch
from
139d560 to
3f4d645
Compare
szh
previously requested changes
Aug 10, 2022
conjur_api/http/api.py
Outdated
Comment on lines
180
to
181
| if err.status == 401: | ||
| return False |
There was a problem hiding this comment.
I think 401 should only happen if there's an authentication error, see the conjur docs. This should presumably be raised as an exception.
There was a problem hiding this comment.
fixed in most recent update
juniortaeza
force-pushed
the
check-command-branch
branch
from
945e1b7 to
34f66a8
Compare
juniortaeza
force-pushed
the
check-command-branch
branch
4 times, most recently
from
adb7a6f to
a72e466
Compare
juniortaeza
force-pushed
the
check-command-branch
branch
from
febbc78 to
bc5e667
Compare
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
Added functionality for the check command in the API side
Implemented Changes
Connected Issue/Story
ONYX-23082