Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role memberships endpoint #33

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Add role memberships endpoint #33

merged 1 commit into from
Aug 5, 2022

Conversation

gl-johnson
Copy link
Contributor

Desired Outcome

Support the Role Membership endpoint. Default behavior should use the recursive membership method (?all), but also support direct membership only queries (?memberships).

Implemented Changes

Added the following URL template and relevant API methods to return a JSON list of role memberships:
ROLES_MEMBERSHIPS = "{url}/roles/{account}/{kind}/{identifier}?{membership}"

Connected Issue/Story

CyberArk internal issue link: ONYX-24035

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@gl-johnson gl-johnson force-pushed the add-role-memberships branch 2 times, most recently from badc0fc to 25b156a Compare August 3, 2022 21:07
@gl-johnson gl-johnson marked this pull request as ready for review August 3, 2022 21:08
@gl-johnson gl-johnson requested a review from a team as a code owner August 3, 2022 21:08
@szh
Copy link
Contributor

szh commented Aug 4, 2022

Looks good. I just want to wait until you have a draft PR in the CLI so I can see the integration tests and verify the output is the same as in the Ruby API.

@szh szh self-requested a review August 4, 2022 13:23
@gl-johnson gl-johnson force-pushed the add-role-memberships branch from 25b156a to 26a155b Compare August 4, 2022 16:04
@gl-johnson
Copy link
Contributor Author

CLI PR with integration tests

Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gl-johnson gl-johnson merged commit 18a6606 into main Aug 5, 2022
@gl-johnson gl-johnson deleted the add-role-memberships branch August 5, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants