Remove v4 #139
Merged
Remove v4 #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtuttle
commented
Nov 17, 2022
| @@ -11,27 +11,10 @@ const ( | |||
| TimeFormatToken4 = "2006-01-02 15:04:05 MST" | |||
| ) | |||
|
|
|||
| type AuthnToken interface { | |||
There was a problem hiding this comment.
Interface is no longer needed since we're not doing any polymorphism w/ v4 vs v5 tokens.
jtuttle
commented
Nov 17, 2022
| @@ -3,13 +3,11 @@ | |||
| export compose_file="../docker-compose.yml" | |||
|
|
|||
| function announce() { | |||
| BLUE='\033[0;34m' | |||
There was a problem hiding this comment.
This was just super hard to read on default terminal colors so I ditched it.
jtuttle
commented
Nov 17, 2022
| router Router | ||
| } | ||
|
|
||
| type Router interface { |
There was a problem hiding this comment.
I moved all the methods defined in this interface directly into client.go for now.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all references to Conjur v4, which is no longer supported.