Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update summon to v0.9.5 #156

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Update summon to v0.9.5 #156

merged 1 commit into from
Nov 15, 2022

Conversation

gl-johnson
Copy link
Contributor

@gl-johnson gl-johnson commented Nov 15, 2022

Desired Outcome

Update Summon to v0.9.5 to address golang.org/x/net and golang.org/x/text vulnerabilities.

Implemented Changes

Update Summon in go.mod.

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@gl-johnson gl-johnson force-pushed the update-summon-dependency branch from 98fe5ec to f64e681 Compare November 15, 2022 16:17
Copy link
Contributor

@andytinkham andytinkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gl-johnson this is looking good. Could you also update the NOTICES.txt file, please? Looks like that has the summon version in it as well. I didn't check the other libraries you bumped here, too, so there might be more changes in that file, too.

@gl-johnson gl-johnson force-pushed the update-summon-dependency branch from f64e681 to ef89f9f Compare November 15, 2022 18:01
@gl-johnson gl-johnson force-pushed the update-summon-dependency branch from ef89f9f to f54e584 Compare November 15, 2022 18:03
@gl-johnson gl-johnson marked this pull request as ready for review November 15, 2022 18:06
@gl-johnson gl-johnson requested a review from a team as a code owner November 15, 2022 18:06
Copy link
Contributor

@andytinkham andytinkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gl-johnson!

@gl-johnson gl-johnson merged commit 4302267 into main Nov 15, 2022
@gl-johnson gl-johnson deleted the update-summon-dependency branch November 15, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants