Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove conjur-intro submodule from build #198

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Remove conjur-intro submodule from build #198

merged 2 commits into from
Sep 28, 2023

Conversation

gl-johnson
Copy link
Contributor

@gl-johnson gl-johnson commented Sep 27, 2023 •
edited
Loading

Address issues with the previous version uploading to Automation Hub:

  • dev folder included in binary, resulting in sanity check and linting errors
  • Bump requires_ansible key to >= 2.13

Also preps to release a new version (v1.2.2) with these changes

@gl-johnson gl-johnson changed the title Remove conjur-intro submodule Remove conjur-intro submodule from build Sep 27, 2023
@gl-johnson gl-johnson marked this pull request as ready for review September 27, 2023 20:24
@gl-johnson gl-johnson requested a review from a team as a code owner September 27, 2023 20:24
@gl-johnson gl-johnson marked this pull request as draft September 28, 2023 15:19
@gl-johnson gl-johnson marked this pull request as ready for review September 28, 2023 15:51
john-odonnell
john-odonnell approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@john-odonnell john-odonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gl-johnson gl-johnson merged commit 0b27d36 into main Sep 28, 2023
@gl-johnson gl-johnson deleted the remove-submodule branch September 28, 2023 16:55
@gl-johnson gl-johnson mentioned this pull request Oct 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-odonnell john-odonnell john-odonnell approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gl-johnson @john-odonnell