-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python #11
Comments
Hi @briannd81 |
I'd like to do both AWS and azure. Should I do a pull request when done so
you can review?
…On Tue, Aug 11, 2020, 2:52 AM Asaf Hecht ***@***.***> wrote:
Hi @briannd81 <https://github.com/briannd81>
Sure, you can go ahead and develop a python version for the scans (I also
had this idea for a while).
Would you like to develop a python version for AWStealth only or also for
AzureStealth?
When you done, of course, we will need to test it in multiple environment,
and when it's in good shape, I can add it to the SkyArk repository and
attribute the python version to you with a thank note on your help and
contribution.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHJKWNC5PKESEZG5ZMRLPO3SADTCBANCNFSM4P2OAJIQ>
.
|
Yes great, do a pull request and I will review it. |
Yeah that makes sense. I was going to build components and import into the
main script as modules to make it easier to maintain and to do unit
testing. But given that the script isn't too complex, I can create a single
script the same as PowerShell. I'm also planning to create the final report
in html in addition to txt to make it easier to navigate to various
sections.
…On Tue, Aug 11, 2020, 8:48 AM Asaf Hecht ***@***.***> wrote:
Yes great, do a pull request and I will review it.
My suggestion - just add one .py script file to each scanning module
folder:
https://github.com/cyberark/SkyArk/tree/master/AWStealth
https://github.com/cyberark/SkyArk/tree/master/AzureStealth
So there will be one .ps file for people who choose to use PowerShell, and
one .py file for the Python lovers.
You can copy all the existing scans logic, just make sure the new Python
scans are still efficient (memory and time) and you write some information
on the progress of the scan, including providing final report and csv.
Tell me if you have additional questions or need any more feedback, you
can contact me via Twitter @Hechtov <https://github.com/Hechtov> or send
me an email ***@***.***
Thanks for your contribution! I know that a Python version will help the
cloud community, so well done 👍
Asaf
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHJKWNEIHVAFCM2JSXDRWQLSAE43DANCNFSM4P2OAJIQ>
.
|
Html report will be awesome! |
I'm interested in a python version as well. I'm not a great python coder but happy to contribute as much as I can @briannd81 |
I would like to build a python for SkyArk. How can I contribute?
The text was updated successfully, but these errors were encountered: