Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Riseup tests improvements #1

Closed
wants to merge 10 commits into from
Closed

Conversation

cyBerta
Copy link
Owner

@cyBerta cyBerta commented Mar 4, 2023

Checklist

Description

This MR aims to improve the data quality of RiseupVPN tests by reduce the amount of false positives due to server side issues.
Major changes are:

  • API failures are reported, but not necessarily a reason to stop the test early
  • invalid CA's are indicated but not considered a failure and the tests will continue without TLS verification
  • a blocked API will be indicated as well, but tried to be circumvented with a Tor+Snowflake tunnel.
  • the API is only considered blocked if the main configuration end point is unreachable, RiseupVPN has multiple ways to get around other other API blockages or server side misbehavior (targets riseupvpn: https://api.black.riseup.net:9001/json: connection_refused ooni/probe#1842 (comment))
  • overloaded gateways are not tested anymore
  • only a subset of gateways are tested

@cyBerta cyBerta force-pushed the riseup_tests_improvements branch from 8e8d599 to 6349b29 Compare March 6, 2023 14:09
cyBerta added 3 commits March 6, 2023 15:17
…r the ca was invalid. Instead of early returning the test, we can still gather the necessary configs to run the gateway tests. This change implies that there might occur multiple failures while fetching data from the API, which is why TestKeys.APIFailures becomes a string array.
… longer skipped, API config data is fetched even if CA cert is invalid or missing
@cyBerta cyBerta force-pushed the riseup_tests_improvements branch from 6349b29 to ef38cec Compare March 6, 2023 14:20
@coveralls
Copy link

coveralls commented Mar 6, 2023

Pull Request Test Coverage Report for Build 4471791066

  • 111 of 111 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 69.978%

Totals Coverage Status
Change from base Build 4328715146: 0.1%
Covered Lines: 17139
Relevant Lines: 24492

💛 - Coveralls

@cyBerta
Copy link
Owner Author

cyBerta commented Mar 18, 2023

Another TODO:

  • figure out if we can run obfs4 handshake tests
    EDIT: will be done in a separate MR

@cyBerta cyBerta mentioned this pull request Mar 20, 2023
4 tasks
@cyBerta cyBerta changed the title DRAFT: Riseup tests improvements Riseup tests improvements Mar 20, 2023
@cyBerta cyBerta closed this Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants