forked from ooni/probe-cli
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Riseup tests improvements #1
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyBerta
force-pushed
the
riseup_tests_improvements
branch
from
March 6, 2023 14:09
8e8d599
to
6349b29
Compare
…r the ca was invalid. Instead of early returning the test, we can still gather the necessary configs to run the gateway tests. This change implies that there might occur multiple failures while fetching data from the API, which is why TestKeys.APIFailures becomes a string array.
…I was considered to be blocked
… longer skipped, API config data is fetched even if CA cert is invalid or missing
cyBerta
force-pushed
the
riseup_tests_improvements
branch
from
March 6, 2023 14:20
6349b29
to
ef38cec
Compare
Pull Request Test Coverage Report for Build 4471791066
💛 - Coveralls |
…sting, avoid those known to be overloaded.
…ducing the amount of tested gateways
cyBerta
commented
Mar 10, 2023
cyBerta
commented
Mar 10, 2023
…4 bridges, avoid hard-coding locations in the test
Another TODO:
|
…sideration for APIStatus blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This MR aims to improve the data quality of RiseupVPN tests by reduce the amount of false positives due to server side issues.
Major changes are: