Fix a bug where basepath nextUrl is invalid when it should be valid (o…

…pensearch-project#2096) * Fix a bug where basepath nextUrl is invalid when it should be valid Signed-off-by: Derek Ho <[email protected]> * Udpate test Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]>
cwperks · Aug 21, 2024 · b1148fb · b1148fb
1 parent 487c571
commit b1148fb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/server/utils/next_url.test.ts b/server/utils/next_url.test.ts
@@ -104,6 +104,11 @@ describe('test validateNextUrl', () => {
     expect(validateNextUrl(url, '')).toEqual(undefined);
   });
 
+  test('allow basePath', () => {
+    const url = '/osd';
+    expect(validateNextUrl(url, '/osd')).toEqual(undefined);
+  });
+
   test('allow dashboard url', () => {
     const url =
       '/_plugin/opensearch-dashboards/app/opensearch-dashboards#dashbard/dashboard-id?_g=(param=a&p=b)';

diff --git a/server/utils/next_url.ts b/server/utils/next_url.ts
@@ -73,7 +73,7 @@ export function validateNextUrl(
     }
     const pathMinusBase = path.replace(bp, '');
     if (
-      !pathMinusBase.startsWith('/') ||
+      (pathMinusBase && !pathMinusBase.startsWith('/')) ||
       (pathMinusBase.length >= 2 && !/^\/[a-zA-Z_][\/a-zA-Z0-9-_]+$/.test(pathMinusBase))
     ) {
       return INVALID_NEXT_URL_PARAMETER_MESSAGE;