Add draft support for basketball #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements draft support for basketball. Copied over from the football implementation. Only change is the string representation in order to better display the round and pick number. This should probably be moved to a base pick class, similar to what is planned for players with cwendt94#124 , but this should do for now. Might also be worth considering adding a player object member instead of the separate name and id-- similar to how the team member is a team object
Closed
Codecov ReportBase: 80.73% // Head: 81.08% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #424 +/- ##
==========================================
+ Coverage 80.73% 81.08% +0.35%
==========================================
Files 59 60 +1
Lines 2050 2083 +33
==========================================
+ Hits 1655 1689 +34
+ Misses 395 394 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Thanks again for another PR! I agree, this could definitely be moved to a base class! I will add it to my TODO for some of the refactoring working I have been wanting to do. |
|
Happy to contribute to the project. Thanks for maintaining it! I'll poke around and see if there's some other stuff I can help with as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements draft support for basketball. Copied over from the football implementation. Only change is the string representation in order to better display the round and pick number.
This should probably be moved to a base pick class, similar to what is planned for players with #124 , but this should do for now. Might also be worth considering adding a player object member instead of the separate name and id-- similar to how the team member is a team object