Add copy constructor support for solver bindings #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B1ueber2y
added a commit
to colmap/colmap
that referenced
this pull request
Dec 18, 2024
For similar purpose as cvg/pyceres#62, just in the other direction.
sarlinpe
approved these changes
Dec 19, 2024
HernandoR
pushed a commit
to HernandoR/colmap
that referenced
this pull request
Dec 30, 2024
…p#3059) For similar purpose as cvg/pyceres#62, just in the other direction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we bring some of the Ceres bindings back to colmap from colmap/colmap#2985, it s better to enable the copying behavior in Python, to be able to use features that in pyceres but not in pycolmap (for example, the callbacks in
SolverOptions). For example, the following code will work after this update:Also, the shared_ptr bindings support are added.