Add ability for the tentacle resource to setup firewall rule for listening tentacles #43
Conversation
| If you manage tentacle firewall though group policy leave 'manage_firewall' `false` | ||
| If you want the cookbook to manage the firewall, set `true` | ||
|
|
||
| node['octopus']['tentacle']['instance']['manage_firewall'] = false |
There was a problem hiding this comment.
I actually have pr #42 to remove attribute files from the cookbook just because they are not used. Everything is using a resource. When this cookbook was first created we did use the attributes but now we do not
|
It looks good I think I would move it to a resource parameter and not include it in the attributes. In addition I think defaulting it to false is the correct way since it is the legacy behavior to not manage it. We can maybe default it in the future once this goes to 1.0.0 |
spuder
force-pushed
the
feature/firewall
branch
2 times, most recently
from
8862601 to
bd6683f
Compare
|
I've gotten rid of the attributes and made a |
spuder
changed the title
brentm5
changed the title
spuder
force-pushed
the
feature/firewall
branch
2 times, most recently
from
56f5849 to
001dfd9
Compare
| - :polling: Whether this Octopus Deploy Instance is a polling tentacle (Defaults to False) | ||
| - :cert_file: Where to export the Octopus Deploy Instance cert (Defaults to C:\Octopus\tentacle_cert.txt) | ||
| - :upgrades_enabled: Whether to upgrade or downgrade the tentacle version if the windows installer version does not match what is provided in the resource. (Defaults to True) | ||
| - :server: Url to Octopus Deploy Server (e.g https://octopus.example.com) | ||
| - :api_key: Api Key used to register Tentacle to Octopus Server | ||
| - :roles: Array of roles to apply to Tentacle when registering with Octopus Deploy Server (e.g ["web-server","app-server"]) | ||
| - :environment: Which environment the Tentacle will become part of when registering with Octopus Deploy Server | ||
| - :environment: Which environment the Tentacle will become part of when registering with Octopus Deploy Server (Defaults to node.chef_environment ) |
There was a problem hiding this comment.
Whoops, that was supposed to be part of #45.
I can separate them if you want.
There was a problem hiding this comment.
If you don't mind. Trying to be somewhat good with feature merges
There was a problem hiding this comment.
Ok, hold off merging until I resquash
spuder
force-pushed
the
feature/firewall
branch
from
001dfd9 to
c7cb71b
Compare
Adds firewall for tentacle
Since polling tentacles don't need the firewall opened, it only applies to listening tentacles.
Defaults to 'false'.
TODO
False is safer for existing cookbook users, but is bound to trip up some new users. I've added a new section to the readme making this more obvious.
Because this is an attribute, some users might have
default['octopus']while others would havedefault['my-octopus']in their wrapper cookbook