Added feature to display dimensions of rectangles and ellipses #9142
Conversation
|
| user-select: none; | ||
| pointer-events: none; | ||
| } | ||
|
|
||
| .cvat_canvas_text_dimensions { | ||
| fill: cyan; |
There was a problem hiding this comment.
Why cyan and not white? It feels we have 2 styles for the same thing now
There was a problem hiding this comment.
To display different things in different colors
When everything is white, it is more difficult to read
|
|
||
| const normWidth = width.toFixed(1); | ||
| const normHeight = height.toFixed(1); | ||
| const normRot = state.rotation === 0 ? '' : `${state.rotation.toFixed(1)}\u00B0`; | ||
|
|
||
| block | ||
| .tspan(`${normWidth}x${normHeight}px ${normRot}`) |
There was a problem hiding this comment.
We have similar code in shared.ts. Maybe there is a way to refactor this logic into separate funciton so we dont do the same thing in 2 places?
There was a problem hiding this comment.
At least generation of text
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9142 +/- ##
===========================================
+ Coverage 73.16% 73.17% +0.01%
===========================================
Files 446 446
Lines 45661 45675 +14
Branches 3907 3912 +5
===========================================
+ Hits 33408 33423 +15
+ Misses 12253 12252 -1
|
Motivation and context
Added setting to display shape size of rectangles and ellipses without dragging/resizing them:
How has this been tested?
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.