-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Helm] Fixed export when disableDistinctCachePerService is false (by default) #9008
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9008 +/- ##
========================================
Coverage 73.39% 73.39%
========================================
Files 415 416 +1
Lines 44192 44198 +6
Branches 3859 3860 +1
========================================
+ Hits 32435 32441 +6
Misses 11757 11757
|
will it fix the online version, at cvat.ai ? |
@Gabriellgpc , it will, but we need to deploy the fix. Please give us some time. CVAT Online will work as expected already today. |
Got it. Thank you for the reply @nmanovic |
This PR removes the
disableDistinctCachePerService
setting.Previously this cache was used to cache chunks of data on storage, which is not relevant now.
Currently only events need to be stored before being sent to Vector, and this will always be cached for each service, so these settings are no longer needed.
Motivation and context
How has this been tested?
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.