Bump @ant-design/icons to match antd #8826
Conversation
cvat-ui depends on icons v4, but antd depends on icons v5. Fixing this discrepancy gets rid of a few duplicate dependencies.
WalkthroughThe Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🔇 Additional comments (2)cvat-ui/package.json (2)
The update to
Since this is a major version upgrade (v4 to v5), we should verify that all icon usages in the codebase are compatible with the new version. Please review the search results to ensure:
✅ Verification successfulNo breaking changes impact detected from @ant-design/icons v4 to v5 Based on the analysis of icon imports and usage patterns in the codebase:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Search for @ant-design/icons imports and usages to verify compatibility
# Check direct icon imports
echo "Checking direct icon imports..."
rg -t tsx -t ts "from '@ant-design/icons'" ./cvat-ui/src
# Check icon component usage patterns that might need updates
echo "Checking icon usage patterns..."
rg -t tsx -t ts "<[A-Z][a-zA-Z]*Icon" ./cvat-ui/src
Length of output: 320 Script: #!/bin/bash
# Let's try without file type restrictions since rg doesn't recognize tsx
echo "Checking direct icon imports..."
rg "from '@ant-design/icons'" ./cvat-ui/src
echo -e "\nChecking icon usage patterns..."
rg "<[A-Z][a-zA-Z]*Icon" ./cvat-ui/src
echo -e "\nChecking specific deprecated patterns..."
# Check for type Icon from @ant-design/icons-react which was removed in v5
rg "Icon.*from.*@ant-design/icons-react" ./cvat-ui/src
# Check for createFromIconfontCN which had breaking changes
rg "createFromIconfontCN" ./cvat-ui/src
# Check for two-tone icon usage which had breaking changes
rg "TwoTone" ./cvat-ui/src
Length of output: 22985 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Motivation and context
cvat-ui depends on icons v4, but antd depends on icons v5. Fixing this discrepancy gets rid of a few duplicate dependencies.
How has this been tested?
Checklist
developbranch[ ] I have created a changelog fragment[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
New Features
Bug Fixes