Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Fix clear spelling mistakes and change docstrings and comments to 'YOLO 1.1' instead of the non-existing 'YOLO ZIP 1.0' #8754

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

gboeer
Copy link
Contributor

@gboeer gboeer commented Nov 28, 2024

Fixes clear typos and mistakes in the docs.

Also:
In several comments or docstrings, the data format 'YOLO ZIP 1.0' is mentioned as an example. However, using this identifier will result in an error like "Unknown format specified for the request", since the format is not supported anymore, or maybe it is just referenced by a different name now.

This PR changes those comments in favor of 'YOLO 1.1' as an example format.

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@gboeer gboeer requested a review from SpecLad as a code owner November 28, 2024 12:43
Copy link
Contributor

coderabbitai bot commented Nov 28, 2024

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes in this pull request primarily involve updates to documentation across several files related to the CVAT command-line interface (CLI) and its associated functionalities. The focus of the modifications is the annotation format, which has been updated from 'YOLO ZIP 1.0' to 'YOLO 1.1'. This update is reflected in various method docstrings and the README documentation, ensuring consistency in the expected annotation formats throughout the codebase. No functional changes or alterations to method signatures were made.

Changes

File Path Change Summary
cvat-cli/README.md Updated annotation upload format from 'YOLO ZIP 1.0' to 'YOLO 1.1'.
cvat-cli/src/cvat_cli/_internal/commands.py Updated TaskDump and TaskUpload class descriptions to reflect the new annotation format 'YOLO 1.1'.
cvat-sdk/cvat_sdk/core/proxies/jobs.py Updated import_annotations method documentation to change format from 'YOLO ZIP 1.0' to 'YOLO 1.1'.
cvat-sdk/cvat_sdk/core/proxies/model_proxy.py Updated export_dataset method documentation to change format from 'YOLO ZIP 1.0' to 'YOLO 1.1'.
cvat-sdk/cvat_sdk/core/proxies/projects.py Updated import_dataset method documentation to change format from 'YOLO ZIP 1.0' to 'YOLO 1.1'.
Typographical error in create_from_dataset method default value for dataset_format noted but unchanged.
cvat-sdk/cvat_sdk/core/proxies/tasks.py Updated import_annotations method documentation to change format from 'YOLO ZIP 1.0' to 'YOLO 1.1'.
site/content/en/docs/api_sdk/cli/_index.md Updated CLI documentation for annotation upload format from 'YOLO ZIP 1.0' to 'YOLO 1.1'.

Poem

🐇 In the land of code where annotations play,
A new format blooms, hip-hip-hooray!
From 'ZIP 1.0' to 'YOLO 1.1',
Our docs are fresh, the changes are done.
With every update, our tools grow bright,
Hopping along, we code through the night! 🌙✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 9581b07 and 9d62260.

📒 Files selected for processing (7)
  • cvat-cli/README.md (1 hunks)
  • cvat-cli/src/cvat_cli/_internal/commands.py (2 hunks)
  • cvat-sdk/cvat_sdk/core/proxies/jobs.py (1 hunks)
  • cvat-sdk/cvat_sdk/core/proxies/model_proxy.py (1 hunks)
  • cvat-sdk/cvat_sdk/core/proxies/projects.py (1 hunks)
  • cvat-sdk/cvat_sdk/core/proxies/tasks.py (1 hunks)
  • site/content/en/docs/api_sdk/cli/_index.md (1 hunks)
✅ Files skipped from review due to trivial changes (4)
  • cvat-cli/README.md
  • cvat-cli/src/cvat_cli/_internal/commands.py
  • cvat-sdk/cvat_sdk/core/proxies/jobs.py
  • cvat-sdk/cvat_sdk/core/proxies/model_proxy.py
🔇 Additional comments (2)
cvat-sdk/cvat_sdk/core/proxies/projects.py (1)

55-55: LGTM! Documentation update aligns with the new format.

The docstring update correctly reflects the new 'YOLO 1.1' format instead of the outdated 'YOLO ZIP 1.0'.

Let's verify there are no remaining references to the old format in the codebase:

✅ Verification successful

Documentation update is consistent across the codebase

The search results confirm that all references to YOLO format have been updated consistently. The docstring change in cvat-sdk/cvat_sdk/core/proxies/projects.py aligns with other format references throughout the codebase, where 'YOLO 1.1' is consistently used in documentation, tests, and implementation files.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any remaining references to the old format
rg -i "YOLO ZIP 1.0" --type py --type md

Length of output: 42


Script:

#!/bin/bash
# Let's search for any YOLO format references to ensure consistency
rg -i "yolo.*[0-9]+\.[0-9]+" --type py --type md

# Also search for format-related code to ensure we haven't missed anything
rg -i "format.*['\"]yolo" --type py --type md

Length of output: 21778

cvat-sdk/cvat_sdk/core/proxies/tasks.py (1)

171-171: LGTM! Documentation update aligns with the PR objectives.

The docstring update from 'YOLO ZIP 1.0' to 'YOLO 1.1' is consistent with the PR's goal to update format references.

Let's verify there are no remaining instances of the old format in this file:

✅ Verification successful

Documentation update is complete and accurate

The verification confirms that:

  1. The only YOLO-related reference in the file is the updated docstring with 'YOLO 1.1'
  2. No instances of the old format ('YOLO ZIP 1.0') remain in the file
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for any remaining instances of 'YOLO ZIP 1.0' in the file

# Search for any remaining instances of the old format
rg -i "YOLO ZIP 1.0" "cvat-sdk/cvat_sdk/core/proxies/tasks.py"

# Also check for similar variations that might need updating
rg -i "YOLO.*ZIP.*1\.0" "cvat-sdk/cvat_sdk/core/proxies/tasks.py"

Length of output: 128


Script:

#!/bin/bash
# Let's check for any YOLO-related format strings in the file to ensure completeness
rg -i "yolo" "cvat-sdk/cvat_sdk/core/proxies/tasks.py"

# Also get the full context of the import_annotations method to verify the docstring
ast-grep --pattern 'def import_annotations($$$)' cvat-sdk/cvat_sdk/core/proxies/tasks.py

Length of output: 224

@@ -18,7 +18,7 @@ Overview of functionality:
- List all tasks (supports basic CSV or JSON output)
- Download JPEG frames (supports a list of frame IDs)
- Dump annotations (supports all formats via format string)
- Upload annotations for a task in the specified format (e.g. 'YOLO ZIP 1.0')
- Upload annotations for a task in the specified format (e.g. 'YOLO 1.1')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Found additional instances of YOLO ZIP 1.0 format that need to be updated

Several instances of YOLOv8 formats with version '1.0' were found in cvat/apps/dataset_manager/formats/yolo.py:

  • YOLOv8 Detection (both importer and exporter)
  • YOLOv8 Oriented Bounding Boxes (both importer and exporter)
  • YOLOv8 Segmentation (both importer and exporter)
  • YOLOv8 Pose (both importer and exporter)
  • YOLOv8 Classification (both importer and exporter)
🔗 Analysis chain

LGTM! Format string updated correctly.

The change from 'YOLO ZIP 1.0' to 'YOLO 1.1' aligns with the PR objectives and maintains consistency with other format strings in the documentation.

Let's verify if there are any remaining instances of the old format string in the codebase:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for any remaining instances of the old format string
# Expected: No occurrences of 'YOLO ZIP 1.0' should be found

echo "Searching for 'YOLO ZIP 1.0'..."
rg -i "YOLO ZIP 1.0"

echo "Searching for similar variations..."
rg -i "YOLO.*ZIP.*1\.0"

Length of output: 1272

@gboeer gboeer changed the title Change docstrings and comments to 'YOLO 1.1' instead of the non existing 'YOLO ZIP 1.0' [doc] Fix clear spelling mistakes and change docstrings and comments to 'YOLO 1.1' instead of the non-existing 'YOLO ZIP 1.0' Nov 28, 2024
@gboeer
Copy link
Contributor Author

gboeer commented Nov 28, 2024

The latest commits fix spelling errors and typos in the docs.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.92%. Comparing base (9581b07) to head (fe16be0).
Report is 36 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8754      +/-   ##
===========================================
- Coverage    74.06%   73.92%   -0.14%     
===========================================
  Files          409      409              
  Lines        43784    43957     +173     
  Branches      3984     3986       +2     
===========================================
+ Hits         32428    32497      +69     
- Misses       11356    11460     +104     
Components Coverage Δ
cvat-ui 78.35% <ø> (-0.03%) ⬇️
cvat-server 70.13% <ø> (-0.21%) ⬇️

@zhiltsov-max zhiltsov-max merged commit c0f3b31 into cvat-ai:develop Dec 11, 2024
35 checks passed
@zhiltsov-max
Copy link
Contributor

Thank you for contributing into the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants