-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Fix clear spelling mistakes and change docstrings and comments to 'YOLO 1.1' instead of the non-existing 'YOLO ZIP 1.0' #8754
Conversation
…stead of the non existent 'YOLO ZIP 1.0'
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe changes in this pull request primarily involve updates to documentation across several files related to the CVAT command-line interface (CLI) and its associated functionalities. The focus of the modifications is the annotation format, which has been updated from 'YOLO ZIP 1.0' to 'YOLO 1.1'. This update is reflected in various method docstrings and the README documentation, ensuring consistency in the expected annotation formats throughout the codebase. No functional changes or alterations to method signatures were made. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (7)
cvat-cli/README.md
(1 hunks)cvat-cli/src/cvat_cli/_internal/commands.py
(2 hunks)cvat-sdk/cvat_sdk/core/proxies/jobs.py
(1 hunks)cvat-sdk/cvat_sdk/core/proxies/model_proxy.py
(1 hunks)cvat-sdk/cvat_sdk/core/proxies/projects.py
(1 hunks)cvat-sdk/cvat_sdk/core/proxies/tasks.py
(1 hunks)site/content/en/docs/api_sdk/cli/_index.md
(1 hunks)
✅ Files skipped from review due to trivial changes (4)
- cvat-cli/README.md
- cvat-cli/src/cvat_cli/_internal/commands.py
- cvat-sdk/cvat_sdk/core/proxies/jobs.py
- cvat-sdk/cvat_sdk/core/proxies/model_proxy.py
🔇 Additional comments (2)
cvat-sdk/cvat_sdk/core/proxies/projects.py (1)
55-55
: LGTM! Documentation update aligns with the new format.
The docstring update correctly reflects the new 'YOLO 1.1' format instead of the outdated 'YOLO ZIP 1.0'.
Let's verify there are no remaining references to the old format in the codebase:
✅ Verification successful
Documentation update is consistent across the codebase
The search results confirm that all references to YOLO format have been updated consistently. The docstring change in cvat-sdk/cvat_sdk/core/proxies/projects.py
aligns with other format references throughout the codebase, where 'YOLO 1.1' is consistently used in documentation, tests, and implementation files.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for any remaining references to the old format
rg -i "YOLO ZIP 1.0" --type py --type md
Length of output: 42
Script:
#!/bin/bash
# Let's search for any YOLO format references to ensure consistency
rg -i "yolo.*[0-9]+\.[0-9]+" --type py --type md
# Also search for format-related code to ensure we haven't missed anything
rg -i "format.*['\"]yolo" --type py --type md
Length of output: 21778
cvat-sdk/cvat_sdk/core/proxies/tasks.py (1)
171-171
: LGTM! Documentation update aligns with the PR objectives.
The docstring update from 'YOLO ZIP 1.0' to 'YOLO 1.1' is consistent with the PR's goal to update format references.
Let's verify there are no remaining instances of the old format in this file:
✅ Verification successful
Documentation update is complete and accurate
The verification confirms that:
- The only YOLO-related reference in the file is the updated docstring with 'YOLO 1.1'
- No instances of the old format ('YOLO ZIP 1.0') remain in the file
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for any remaining instances of 'YOLO ZIP 1.0' in the file
# Search for any remaining instances of the old format
rg -i "YOLO ZIP 1.0" "cvat-sdk/cvat_sdk/core/proxies/tasks.py"
# Also check for similar variations that might need updating
rg -i "YOLO.*ZIP.*1\.0" "cvat-sdk/cvat_sdk/core/proxies/tasks.py"
Length of output: 128
Script:
#!/bin/bash
# Let's check for any YOLO-related format strings in the file to ensure completeness
rg -i "yolo" "cvat-sdk/cvat_sdk/core/proxies/tasks.py"
# Also get the full context of the import_annotations method to verify the docstring
ast-grep --pattern 'def import_annotations($$$)' cvat-sdk/cvat_sdk/core/proxies/tasks.py
Length of output: 224
@@ -18,7 +18,7 @@ Overview of functionality: | |||
- List all tasks (supports basic CSV or JSON output) | |||
- Download JPEG frames (supports a list of frame IDs) | |||
- Dump annotations (supports all formats via format string) | |||
- Upload annotations for a task in the specified format (e.g. 'YOLO ZIP 1.0') | |||
- Upload annotations for a task in the specified format (e.g. 'YOLO 1.1') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Found additional instances of YOLO ZIP 1.0 format that need to be updated
Several instances of YOLOv8 formats with version '1.0' were found in cvat/apps/dataset_manager/formats/yolo.py
:
- YOLOv8 Detection (both importer and exporter)
- YOLOv8 Oriented Bounding Boxes (both importer and exporter)
- YOLOv8 Segmentation (both importer and exporter)
- YOLOv8 Pose (both importer and exporter)
- YOLOv8 Classification (both importer and exporter)
🔗 Analysis chain
LGTM! Format string updated correctly.
The change from 'YOLO ZIP 1.0' to 'YOLO 1.1' aligns with the PR objectives and maintains consistency with other format strings in the documentation.
Let's verify if there are any remaining instances of the old format string in the codebase:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Search for any remaining instances of the old format string
# Expected: No occurrences of 'YOLO ZIP 1.0' should be found
echo "Searching for 'YOLO ZIP 1.0'..."
rg -i "YOLO ZIP 1.0"
echo "Searching for similar variations..."
rg -i "YOLO.*ZIP.*1\.0"
Length of output: 1272
The latest commits fix spelling errors and typos in the docs. |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8754 +/- ##
===========================================
- Coverage 74.06% 73.92% -0.14%
===========================================
Files 409 409
Lines 43784 43957 +173
Branches 3984 3986 +2
===========================================
+ Hits 32428 32497 +69
- Misses 11356 11460 +104
|
Thank you for contributing into the project! |
Fixes clear typos and mistakes in the docs.
Also:
In several comments or docstrings, the data format 'YOLO ZIP 1.0' is mentioned as an example. However, using this identifier will result in an error like "Unknown format specified for the request", since the format is not supported anymore, or maybe it is just referenced by a different name now.
This PR changes those comments in favor of 'YOLO 1.1' as an example format.
License
Feel free to contact the maintainers if that's a concern.