-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libhdf5-dev installation #8210
Conversation
WalkthroughThe recent updates to the Dockerfile enhance the image's capabilities by adding the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- Dockerfile (1 hunks)
Additional comments not posted (1)
Dockerfile (1)
23-23
: LGTM! Verify the necessity oflibhdf5-dev
.The addition of the
libhdf5-dev
package appears correct and well-placed within the list of installed packages.However, ensure that this package is indeed required for resolving the build error related to the HDF5 library.
Closing in favour of #8093 |
Motivation and context
How has this been tested?
Checklist
develop
branch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Changes summary
Running command from https://docs.cvat.ai/docs/contributing/development-environment/
Resulted in build error:
Installing
libhdf5-dev
solved the error and allowed image to be built.Summary by CodeRabbit