-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added simple test for analytics availability #4308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests looks good to me, but I have one question. Did you try to see analytics on test DB?
When I tried to do it, analytics dashboards were empty and Kibana raises errors: Unable to update UI setting Request failed with status code: 406
and Error in visualization aggs is undefined
, even though the test database has users and tasks, is this expected behavior for this database?
This error appeared after #4239 PR was merged because it changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@azhavoro I slightly modified the test function so that it doesn't depend on usernames.
About viewing analytics with test db: I tested manually, now all works fine.
Are the changes in this PR related to the failure of UI tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation and context
How has this been tested?
Checklist
develop
branch- [ ] I have added a description of my changes into CHANGELOG file- [ ] I have updated the documentation accordingly- [ ] I have added tests to cover my changes- [ ] I have linked related issues (read github docs)- [ ] I have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.