Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added simple test for analytics availability #4308

Merged
merged 6 commits into from
Feb 16, 2022
Merged

Conversation

azhavoro
Copy link
Contributor

@azhavoro azhavoro commented Feb 9, 2022

Motivation and context

How has this been tested?

Checklist

  • I submit my changes into the develop branch
    - [ ] I have added a description of my changes into CHANGELOG file
    - [ ] I have updated the documentation accordingly
    - [ ] I have added tests to cover my changes
    - [ ] I have linked related issues (read github docs)
    - [ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
    cvat-core, cvat-data and cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2022 Intel Corporation
#
# SPDX-License-Identifier: MIT

@azhavoro azhavoro requested a review from nmanovic as a code owner February 9, 2022 10:42
@sizov-kirill sizov-kirill self-requested a review February 14, 2022 11:02
Copy link
Contributor

@sizov-kirill sizov-kirill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests looks good to me, but I have one question. Did you try to see analytics on test DB?

When I tried to do it, analytics dashboards were empty and Kibana raises errors: Unable to update UI setting Request failed with status code: 406 and Error in visualization aggs is undefined, even though the test database has users and tasks, is this expected behavior for this database?

@azhavoro
Copy link
Contributor Author

Tests looks good to me, but I have one question. Did you try to see analytics on test DB?

When I tried to do it, analytics dashboards were empty and Kibana raises errors: Unable to update UI setting Request failed with status code: 406 and Error in visualization aggs is undefined, even though the test database has users and tasks, is this expected behavior for this database?

This error appeared after #4239 PR was merged because it changes accept header for all CVAT endpoints, should be fixed now.

Copy link
Contributor

@sizov-kirill sizov-kirill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azhavoro I slightly modified the test function so that it doesn't depend on usernames.

About viewing analytics with test db: I tested manually, now all works fine.

Are the changes in this PR related to the failure of UI tests?

Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmanovic nmanovic merged commit 3c8922e into develop Feb 16, 2022
@nmanovic nmanovic deleted the az/analytics_test branch February 16, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants