-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Bug 4010 - API method to register does not return authentification token #4092
Conversation
When email verification is turned off using all-auth settings, then on registration, return the auth token key.
Hi, @g-kartik Thank your for the contribution! |
Okay, Thank you! |
Split the test case for user registration without email verification into two test cases by overriding ACCOUNT_EMAIL_VERIFICATION as 'none' and 'optional'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contribution!
Motivation and context
fixes #4010
When email verification is turned off in the all-auth settings, the rest-register api does not return auth-token key. This pull request solves the issue by returning the key in this condition.
Changes:
How has this been tested?
Tests
python manage.py test cvat.apps.iam.tests
to run the testsChecklist
develop
branch[ ] I have updated the documentation accordingly[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.