Optimizing getting cloud storage #3776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marishka17
changed the title
Marishka17
force-pushed
the
mk/optimize_getting_cloud_storages
branch
from
9a55eb8 to
4235719
Compare
Marishka17
changed the title
bsekachev
reviewed
Oct 11, 2021
cvat-ui/src/reducers/interfaces.ts
Outdated
| initialized: boolean; | ||
| id: number | null; | ||
| preview: string; | ||
| error: string | null; |
There was a problem hiding this comment.
Do you really need to store error in global state for CloudStoragePreview and CloudStorageStatus?
cvat-ui/src/reducers/interfaces.ts
Outdated
Comment on lines
138
to
149
| fetching: boolean; | ||
| initialized: boolean; | ||
| id: number | null; | ||
| status: string | null; | ||
| error: string | null; | ||
| } | ||
|
|
||
| export interface CloudStoragePreview { | ||
| fetching: boolean; | ||
| initialized: boolean; | ||
| id: number | null; | ||
| preview: string; |
There was a problem hiding this comment.
Can we reduce code duplication using typescript Pick?
cvat-ui/src/reducers/interfaces.ts
Outdated
Comment on lines
138
to
142
| fetching: boolean; | ||
| initialized: boolean; | ||
| id: number | null; | ||
| status: string | null; | ||
| error: string | null; |
There was a problem hiding this comment.
Don't you think if it be like this:
[index: number]: {
fetching: boolean;
initialized: boolean;
id: number | null;
status: string | null;
error: string | null;
}
reducers and useSelectors callback would be easier?
bsekachev
reviewed
Oct 11, 2021
cvat-ui/src/reducers/interfaces.ts
Outdated
| preview: string; | ||
| error: string | null; | ||
| } | ||
| type CloudStorageStatus = Pick<CloudStorageAdditional, 'fetching' | 'initialized' | 'id' | 'error' | 'status'>; |
There was a problem hiding this comment.
Do we need id field here if it is a key now?
Marishka17
changed the title
Marishka17
changed the title
bsekachev
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Resolve #3759
How has this been tested?
Manually
Checklist
developbranch- [ ] I have added tests to cover my changescvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.