-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project tasks loading only when needed #3223
Conversation
@ActiveChooN @dvkruchinin |
Sure. I`ll take a look. |
|
||
const [project] = projects.filter((_project) => _project.id === id); | ||
const projectSubsets = ['']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No subset assigned
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a default value for the task without a subset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, just on UI we could rename it as we wish for better UX, right?
BTW, should not we paginate project tasks? Now it lists (and fetches from the server) all the tasks. It is probably inefficient. Another question is how to list such tasks considering several subsets. |
I looked at it. This is similar to a situation that has already occurred (https://github.com/openvinotoolkit/cvat/pull/3001/files). In this PR, a horizontal scroll bar appears. |
Co-authored-by: Boris Sekachev <[email protected]>
Remark lint failed due to empty bullet list items. I Will check other related test failures.
Yes, it's a good idea. And better way to do it on a server and just to order tasks by subset and filter by project, then cache responses on a client. But it looks like a separate feature. |
Motivation and context
Resolve #3128. Trying to avoid unnecessary requests while fetching projects API.
How has this been tested?
Manually
Checklist
develop
branch- [ ] I have updated the documentation accordingly- [ ] I have added tests to cover my changescvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.