Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cypress test. Hotkeys to change labels feature. #3086

Merged
merged 2 commits into from
Apr 13, 2021
Merged

Cypress test. Hotkeys to change labels feature. #3086

merged 2 commits into from
Apr 13, 2021

Conversation

dvkruchinin
Copy link
Contributor

Motivation and context

Add cypress test to check #3070 #3084

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@dvkruchinin dvkruchinin requested a review from azhavoro as a code owner April 13, 2021 11:54
@coveralls
Copy link

coveralls commented Apr 13, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 74.055% when pulling 4a941bf on dvkruchinin:dkru/cypress-test-case-72-hotkeys-change-labels-feature into 085d260 on openvinotoolkit:develop.

@bsekachev bsekachev self-requested a review April 13, 2021 13:14
@bsekachev bsekachev self-assigned this Apr 13, 2021
bsekachev
bsekachev reviewed Apr 13, 2021
View reviewed changes
tests/cypress/integration/actions_tasks_objects/case_72_hotkeys_change_labels.js Outdated
});
});

it('Changing a lebel for shape via hotkey.', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
it('Changing a lebel for shape via hotkey.', () => {
it('Changing a label for a shape using hotkey.', () => {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fixed.

tests/cypress/integration/actions_tasks_objects/case_72_hotkeys_change_labels.js Outdated
testCheckingAlwaysShowObjectDetails();
});

it('Changing default lebel before drawing a shape.', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
it('Changing default lebel before drawing a shape.', () => {
it('Changing default label before drawing a shape.', () => {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@bsekachev bsekachev merged commit a2170f7 into cvat-ai:develop Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsekachev bsekachev bsekachev approved these changes

@azhavoro azhavoro Awaiting requested review from azhavoro azhavoro is a code owner

Assignees

@bsekachev bsekachev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dvkruchinin @coveralls @bsekachev