Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label deleting #2881

Merged
merged 14 commits into from
Mar 18, 2021
Merged

Label deleting #2881

merged 14 commits into from
Mar 18, 2021

Conversation

ActiveChooN
Copy link
Contributor

@ActiveChooN ActiveChooN commented Mar 1, 2021 •
edited
Loading

Motivation and context

This PR provide functionality to delete label from UI. Added special field deleted for this purpose in label schema. Neede for tasks moving into project functionality.

How has this been tested?

Manually

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@coveralls
Copy link

coveralls commented Mar 1, 2021 •
edited
Loading

Coverage Status

Coverage increased (+3.3%) to 75.568% when pulling c38f3f7 on dk/label-deleting into 86eef84 on develop.

@bsekachev bsekachev self-assigned this Mar 1, 2021
@ActiveChooN ActiveChooN requested a review from azhavoro as a code owner March 5, 2021 15:35
@ActiveChooN ActiveChooN changed the title [WIP] Label deleting Label deleting Mar 15, 2021
@dvkruchinin dvkruchinin mentioned this pull request Mar 15, 2021
Merged
8 tasks
bsekachev
bsekachev previously approved these changes Mar 18, 2021
View reviewed changes
nmanovic
nmanovic previously approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The server part looks OK.

@bsekachev bsekachev dismissed stale reviews from nmanovic and themself via e269d4a March 18, 2021 12:30
@bsekachev bsekachev merged commit 16bc9fb into develop Mar 18, 2021
@bsekachev bsekachev deleted the dk/label-deleting branch March 18, 2021 12:59
@ActiveChooN ActiveChooN mentioned this pull request May 7, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmanovic nmanovic nmanovic left review comments

@bsekachev bsekachev bsekachev left review comments

@azhavoro azhavoro Awaiting requested review from azhavoro azhavoro is a code owner

Assignees

@bsekachev bsekachev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ActiveChooN @coveralls @bsekachev @nmanovic