Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cypress test for issue 1498 #2083

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Cypress test for issue 1498 #2083

merged 2 commits into from
Sep 1, 2020

Conversation

dvkruchinin
Copy link
Contributor

Add Cypress test for issue 1498

Motivation and context

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@dvkruchinin dvkruchinin requested a review from azhavoro as a code owner August 25, 2020 14:32
@coveralls
Copy link

coveralls commented Aug 25, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 7190

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.747%
Totals Coverage Status
Change from base Build 7189: 0.0%
Covered Lines: 11754
Relevant Lines: 16396
💛 - Coveralls

bsekachev
bsekachev reviewed Aug 31, 2020
View reviewed changes
tests/cypress/integration/issue_1498_message_ui_raw_labels_wrong.js Outdated
before(() => {
cy.visit('auth/login')
cy.login()
cy.contains('button', 'Create new task').click()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use id cvat-create-task-button to get the element

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Also changed it in the "createAnnotationTask" command.

@dvkruchinin dvkruchinin force-pushed the dkru/cypress_test_issue_1498 branch from 7f2b63a to 465d4a7 Compare August 31, 2020 11:50
@dvkruchinin dvkruchinin force-pushed the dkru/cypress_test_issue_1498 branch from 465d4a7 to 30482e6 Compare August 31, 2020 13:55
@bsekachev bsekachev merged commit 7acd8dd into cvat-ai:develop Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsekachev bsekachev bsekachev approved these changes

@azhavoro azhavoro Awaiting requested review from azhavoro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dvkruchinin @coveralls @bsekachev