-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Datumaro] Reducing nesting of tests #1875
Conversation
Pull Request Test Coverage Report for Build 6397
💛 - Coveralls |
Could you fill the PR description? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please fix conflicts so it could be merged.
Here is an overview of what got changed by this pull request: Complexity increasing per file
==============================
- datumaro/tests/test_mot_format.py 1
- datumaro/tests/test_coco_format.py 3
See the complete overview on Codacy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice.
Motivation and context
Tests are complex. It's necessary to reduce nesting.
To achieve this goal was implemented Dataset.from_iterable(), labelCategories.from_iterable()
and PointsCategories.from_iterable(). The format tests was simplified.
How has this been tested?
It was tested using unittests.
Checklist
develop
branchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.