Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functionality to upload annotations on task creation #1735

Merged
merged 14 commits into from
Jun 22, 2020
Merged

Functionality to upload annotations on task creation #1735

merged 14 commits into from
Jun 22, 2020

Conversation

egrinstein
Copy link
Contributor

@egrinstein egrinstein commented Jun 17, 2020

Motivation and context

Sometimes I have some base annotations I want to add to a task when I create them (for QA, for example). Discussed with @nmanovic at #1453

How has this been tested?

I have tested this locally by uploading tasks of different sizes.

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Copy link
Contributor

@azhavoro azhavoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!
Could you please fix tests:

ERROR: test_tasks_list (tests._test_cli.TestCLI)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3.5/unittest/mock.py", line 1157, in patched
    return func(*args, **keywargs)
  File "/home/django/utils/cli/tests/_test_cli.py", line 32, in setUp
    [self.img_file])
TypeError: tasks_create() missing 3 required positional arguments: 'annotation_path', 'annotation_format', and 'cooldown_period_in_secs'

utils/cli/core/core.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jun 18, 2020

Pull Request Test Coverage Report for Build 6053

  • 9 of 21 (42.86%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 65.436%

Changes Missing Coverage Covered Lines Changed/Added Lines %
utils/cli/core/core.py 6 18 33.33%
Totals Coverage Status
Change from base Build 6048: -0.03%
Covered Lines: 10959
Relevant Lines: 16338

💛 - Coveralls

@egrinstein egrinstein requested a review from azhavoro June 18, 2020 23:34
azhavoro
azhavoro previously approved these changes Jun 19, 2020
Copy link
Contributor

@azhavoro azhavoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmanovic
Copy link
Contributor

@egrinstein , thanks for the contribution!

@nmanovic nmanovic merged commit 3fee4cf into cvat-ai:develop Jun 22, 2020
@egrinstein
Copy link
Contributor Author

@nmanovic you welcome, thanks for all the help and the great product.

frndmg pushed a commit to signatrix/cvat that referenced this pull request Aug 5, 2020
* Upload annotations on task creation

* Bulk upload v1

* Not working

* Annotation upon task creation finished

* Functionality to upload annotations on task creation

* Functionality to upload annotations on task creation

* Functionality to upload annotations on task creation

* Functionality to upload annotations on task creation

* Fix trailing whitespace

* Use status request for checking task completion

* fixed default format name

Co-authored-by: Eric Grinstein <[email protected]>
Co-authored-by: Andrey Zhavoronkov <[email protected]>
Co-authored-by: Nikita Manovich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants