Issues related to tasks with honeypots #8686
Assignees
Labels
bug
Something isn't working
Comments
|
Job list performance was improved in #8275, it's because of inefficient field access in IAM. |
7 tasks
zhiltsov-max
added a commit
that referenced
this issue
Dec 19, 2024
<!-- Raise an issue to propose your change (https://github.com/cvat-ai/cvat/issues). It helps to avoid duplication of efforts from multiple independent contributors. Discuss your ideas with maintainers to be sure that changes will be approved and merged. Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/). --> <!-- Provide a general summary of your changes in the Title above --> ### Motivation and context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. Describe your changes in detail, add screenshots. --> Fixes #8686 Includes #8689 - Optimized task validation layout updates - Refactored `take_by` and `chunked_list` uses in the server code - Fixed response values and reroll logic when both `disabled_frames` and `frame_selection_method` are used simultaneously in `PATCH /tasks/id/validation_layout` - Fixed missing context image chunks cleanup on honeypot changes in jobs and tasks - Fixed invalid context image chunk cache keys ### How has this been tested? <!-- Please describe in detail how you tested your changes. Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc. --> ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I submit my changes into the `develop` branch - [ ] I have created a changelog fragment <!-- see top comment in CHANGELOG.md --> - [ ] I have updated the documentation accordingly - [ ] I have added tests to cover my changes - [ ] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)) - [ ] I have increased versions of npm packages if it is necessary ([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning), [cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning), [cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning) and [cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning)) ### License - [ ] I submit _my code changes_ under the same [MIT License]( https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes - **New Features** - Enhanced honeypot task functionality for improved validation frame selection and randomization. - Introduced a new class for managing frame selection, ensuring uniform usage across tasks. - **Bug Fixes** - Improved error handling and validation checks in task management and annotation processes. - **Tests** - Expanded test coverage for task creation, validation frame management, and annotation import/export, ensuring robust functionality. - **Documentation** - Updated internal documentation to reflect new features and changes in task management processes. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Maria Khrustaleva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Actions before raising this issue
Steps to Reproduce
Check ifGET /jobscan be optimized for tasks with gt_pool validation mode (e.g. in the case of 500 jobs it takes 17s)disabled_framesin task validation layout, outdated data is returned in the responsePATCH /tasks/id/validation_layoutFor instance, when disabling one validation frame and shuffling honeypots:
Request duration: 114254 ms
Expected Behavior
No response
Possible Solution
No response
Context
No response
Environment
- git commit: 1e7ff33The text was updated successfully, but these errors were encountered: