Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other tensorflow object detection models #196

Closed
kodonnell opened this issue Nov 16, 2018 · 7 comments · Fixed by #1767
Closed

Support other tensorflow object detection models #196

kodonnell opened this issue Nov 16, 2018 · 7 comments · Fixed by #1767
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@kodonnell
Copy link

Currently one can run other models using TF_ANNOTATION_MODEL_PATH (see here) - though I guess you'd need to modify this in the dockerfile somehow (maybe here - though you'd still need to get the file onto the image).

however, the class labels are hard-coded which, in practice, means only a small subset of tensorflow object detections will work (i.e. those trained on COCO (?) which hopefully have the class names in the correct order).

Happy to submit a PR. I was thinking of doing something hacky-ish like reading the classes from a json at TF_ANNOTATION_CLASSES_PATH but then I realised that this isn't that great, as the same model would be used on all tasks i.e. you couldn't use model X for one annotation task, and model Y for another. So, I'm thinking that in the GUI, the user can upload a model (frozen graph + classes), which gets used - in the same way we upload videos etc. I feel like this should be pretty straightforward plumbing, since all of the code to run the model etc. already exists.

If that sounds like a good idea, I can have a play. Otherwise, if it's a bad idea, can someone propose an alternative? And - if there's not enough interest in this feature, then I can just hack something out for my own use case (which will be much quicker and easier for me, after all).

@nmanovic nmanovic changed the title Feature request: support other tensorflow object detection models Support other tensorflow object detection models Nov 16, 2018
@nmanovic nmanovic added this to the Backlog milestone Nov 16, 2018
@nmanovic
Copy link
Contributor

@kodonnell ,

We are working to implement the feature already. I hope to add it next year.

@nmanovic nmanovic added the enhancement New feature or request label Nov 16, 2018
@savan77
Copy link
Contributor

savan77 commented Nov 16, 2018

we have already implemented this feature for our local usage and working on adding tracking for videos. we are also planning to open-source once everything is tested thoroughly.

@nmanovic
Copy link
Contributor

@savan77 ,

Awesome. Don't hesitate to send as PR. We are open for collaboration.

@kodonnell
Copy link
Author

@savan77 - great work. Maybe if you submit a PR now, then we can also try it out and test it?

@savan77
Copy link
Contributor

savan77 commented Nov 19, 2018

@kodonnell @nmanovic
I am more than happy to send a PR but I am just a developer not an owner. However, I have been told that the code will be open-sourced soon. I can't comment on exactly when.

@outan
Copy link

outan commented Nov 28, 2018

@kodonnell @nmanovic
I am more than happy to send a PR but I am just a developer not an owner. However, I have been told that the code will be open-sourced soon. I can't comment on exactly when.

I am very happy to wait for your PR.
I really need the tracking feature in my project to greatly reduce annotation time.
And I think that is needed in many projects.

@zishanahmed08
Copy link

@savan77 any updates?

@nmanovic nmanovic modified the milestones: Backlog, 1.1.0-beta Jul 14, 2020
TOsmanov pushed a commit to TOsmanov/cvat that referenced this issue Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants