Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message in UI when raw labels are wrong #1498

Closed
smartnet-club opened this issue May 6, 2020 · 5 comments · Fixed by #1727
Closed

Add message in UI when raw labels are wrong #1498

smartnet-club opened this issue May 6, 2020 · 5 comments · Fixed by #1727
Assignees
Labels
bug Something isn't working
Milestone

Comments

@smartnet-club
Copy link

While creating new task, Raw label field doesn't work.

Expected Behaviour

Labels created by Raw field

Current Behaviour

Pressing Done, labels appear in Constructor field, but on Submit the error:
Could not create a task
A task must contain at least one label

Possible Solution

Steps to Reproduce (for bugs)

  1. Open new task page.
  2. Fill Raw field by label json and press Done
  3. Fill other task fields
  4. Pres Submit

Context

Your Environment

  • Git hash commit (git log -1): commit 011c4aa (HEAD, tag: v1.0.0-beta.2, origin/release-1.0.0)
  • Docker version docker version (e.g. Docker 17.0.05):
  • Are you using Docker Swarm or Kubernetes?
  • Operating System and version (e.g. Linux, Windows, MacOS):
  • Code example or link to GitHub repo or gist to reproduce problem:
  • Other diagnostic information / logs:
    Logs from `cvat` container

Next steps

You may join our Gitter channel for community support.

@bsekachev
Copy link
Member

@smartnet-club

Could not reproduce the issue. Could you please provide labels specification you used?

@smartnet-club
Copy link
Author

smartnet-club commented May 6, 2020

[ { "name": "7790895000829", "attributes": [ { "name": "color", "type": "radio", "mutable": false, "values": [ "green" ] }, { "name": "name", "type": "text", "mutable": false, "values": [ "sprite bottle" ] } ] }, { "name": "7790895000782", "attributes": [ { "name": "color", "type": "radio", "mutable": false, "values": [ "black" ] }, { "name": "name", "type": "text", "mutable": false, "values": [ "coke bottle" ] } ] } ]

@bsekachev
Copy link
Member

@smartnet-club

Please change all type to input_type (Related #1284)
But nevertheless we should add a message if specification is wrong.

@smartnet-club
Copy link
Author

Thanks!

@bsekachev
Copy link
Member

Let's leave the issue opened till we have added a warning in UI

@bsekachev bsekachev reopened this May 7, 2020
@bsekachev bsekachev added the bug Something isn't working label May 7, 2020
@bsekachev bsekachev self-assigned this May 7, 2020
@bsekachev bsekachev added this to the 1.0.0-release milestone May 7, 2020
@bsekachev bsekachev changed the title Failed to create labels by Raw fileld Add message in UI when raw labels are wrong May 7, 2020
@nmanovic nmanovic modified the milestones: 1.0.0-release, 1.1.0-beta May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants