Proper typing for getElementsByClass #238
Merged
+73
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not yet implemented for recurse()... When getElementsByClass is passed a single Music21 class, like m21p, now the elements of the StreamIterator will be properly typed. Note that it does not yet work on recurse() -- I want to make sure that even this change doesn't break my projects first. .pitches is moved from NotRest to GeneralNote to match recent changes in m21p. Mixing strings and M21Object classes in lists to getElements calls is no longer allowed. Choose one or the other. turn off eslint checking for dup methods. Typescript checks this for us, and eslint does not know about overload methods. rewrite clef.bestClef with modern looping techniques, and taking advantage of the automatic typing. Add test, including recurse test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not yet implemented for recurse()...
When getElementsByClass is passed a single Music21 class, like m21p, now the elements of the StreamIterator will be properly typed.
Note that it does not yet work on recurse() -- I want to make sure that even this change doesn't break my projects first.
.pitches is moved from NotRest to GeneralNote to match recent changes in m21p.
Mixing strings and M21Object classes in lists to getElements calls is no longer allowed. Choose one or the other.
turn off eslint checking for dup methods. Typescript checks this for us, and eslint does not know about overload methods.
rewrite clef.bestClef with modern looping techniques, and taking advantage of the automatic typing. Add test, including recurse test.