Set sixthMinor and seventhMinor to CAUTIONARY in romanNumeralFromChord() #1230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1217
Fixes #1229
FYI @napulen what do you think?
Clarification: this does not change any default behavior of figure or pitch parsing, but simply sets the attributes on the created RomanNumeral object to reflect how the figure should be interpreted, given the figure it was created with. (i.e., the method creates a cautionary "b" in "bVI", so set
sixthMinor
toCAUTIONARY
.)