Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to postcss 8 #68

Merged
merged 1 commit into from
Mar 6, 2021
Merged

update to postcss 8 #68

merged 1 commit into from
Mar 6, 2021

Conversation

cowills
Copy link
Contributor

@cowills cowills commented Dec 14, 2020

Hello, my team at work uses this plugin and we are hoping to update to postcss 8 in the next few months. The plugin migration looked straightforward so i took a shot at it following this migration guide and using this other plugin PR as an example:

https://evilmartians.com/chronicles/postcss-8-plugin-migration
https://github.com/Genuifx/postcss-pxtorpx-pro/compare/dev-8

  • moved postcss to a peerDependency/devDependency
  • updated the plugin module.exports syntax
  • moved plugin code into the new Declaration and AtRule functions
  • replaced decl.parent.insertAfter with decl.cloneAfter

resolves #66

@yangmingshan
Copy link
Collaborator

@cuth Could you spent a little time to review this PR?

@cuth
Copy link
Owner

cuth commented Mar 5, 2021

Thanks for the ping. I'll review this soon.

@cuth cuth merged commit 993bf53 into cuth:master Mar 6, 2021
@cuth
Copy link
Owner

cuth commented Mar 6, 2021

Thanks!

@cuth
Copy link
Owner

cuth commented Mar 6, 2021

Published 6.0.0 for postcss 8

@yangmingshan
Copy link
Collaborator

yangmingshan commented Mar 7, 2021

Seems you miss the change log, just a reminder 😀. Thanks for your time.

@cuth
Copy link
Owner

cuth commented Mar 7, 2021

@yangmingshan you're right, I did. Definitely should call out breaking changes. Thanks!

@yangmingshan would you be interested in being a maintainer? I've gone through too many life changes and don't have much time for open source right now.

@yangmingshan
Copy link
Collaborator

Yes I'm interested. My npm username is also yangmingshan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to PostCSS 8
3 participants