Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update sample app build info #383

Merged
merged 7 commits into from
Feb 14, 2025
Merged

Conversation

mrehan27
Copy link
Contributor

@mrehan27 mrehan27 commented Feb 12, 2025

part of MBL-746

Changes

  • Updated CI workflow to include workspace name in build information
  • Updated build info to match screenshot attached in linked ticket
  • Added dedicated class and utility functions to primary sample app for easier modification and extraction of build info

Screenshots

Local (with specific SDK version) CI (without specific SDK version)
img_local img_ci

@mrehan27 mrehan27 self-assigned this Feb 12, 2025
@mrehan27 mrehan27 requested a review from a team as a code owner February 12, 2025 09:15
Copy link

github-actions bot commented Feb 12, 2025

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • APN: 383.7.0 (28989403)
  • FCM: 383.7.0 (28989404)

Copy link
Contributor

@Shahroz16 Shahroz16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this going to have the updated commit count in this PR or next?

@mrehan27
Copy link
Contributor Author

@Shahroz16 It's already fixed in this PR. This change should work well and resolve the issue, which is why I had to open another PR in other repos 😅

@mrehan27 mrehan27 merged commit 0e74e8c into main Feb 14, 2025
9 checks passed
@mrehan27 mrehan27 deleted the rehan/mbl-746-build-info branch February 14, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants