feat: add logging for testing background queue #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adding user agent * can import UIKit * Minor fix * conditional import statements * minor fix for deviceInfo. Need to discuss for the 'default value' in case UIKit is unavailable * added test case and comments
# [1.0.0-alpha.17](1.0.0-alpha.16...1.0.0-alpha.17) (2021-11-03) ### Bug Fixes * improve user-agent with more detail ([#74](#74)) ([4301034](4301034))
# [1.0.0-alpha.18](1.0.0-alpha.17...1.0.0-alpha.18) (2021-11-18) ### Bug Fixes * deep links previously being ignored ([#79](#79)) ([2041767](2041767))
q depends on hooks, hooks depend on q.
event bus no longer needed
# [1.0.0-alpha.19](1.0.0-alpha.18...1.0.0-alpha.19) (2021-12-03) ### Bug Fixes * logs now show up in mac console app ([#80](#80)) ([535d0be](535d0be))
levibostian
commented
Dec 7, 2021
Comment on lines
+66
to
+67
| // Do not delete push token from device storage. The token is valid | ||
| // once given to SDK. We need it for future profile identifications. |
There was a problem hiding this comment.
this is a bug that I found after implementing logging and I did some QA testing of the queue myself.
hownowstephen
approved these changes
Dec 8, 2021
|
🎉 This PR is included in version 1.0.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0-beta.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the logging of the background queue and parts of the SDK to make QA testing better.
How to enable logging to test this PR