chore: clear in-app message cache on sdk logout #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of: https://linear.app/customerio/issue/MBL-373/[bug]-in-app-messages-do-not-show-on-ios-if-page-rules-are-enabled-and When SDK is logged out, clear the in-app network cache to prevent displaying messages to the wrong Journeys profile. Testing: * Automated tests added. * QA test case in the linear ticket passed in sample apps. Reviewer notes: * This implementation was chosen to match the behavior of Android 3.11.0
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
SDK binary size reports 📊SDK binary size of this PRSDK binary size diff report between this PR and the main branch |
mrehan27
approved these changes
Jun 25, 2024
…/cache-inapp-response-clear-on-logout
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## levi/cache-inapp-responses-integration-tests #749 +/- ##
================================================================================
+ Coverage 63.16% 63.19% +0.03%
================================================================================
Files 140 140
Lines 3988 3994 +6
================================================================================
+ Hits 2519 2524 +5
- Misses 1469 1470 +1 ☔ View full report in Codecov by Sentry. |
levibostian
merged commit aea7eb6
into
levi/cache-inapp-responses-integration-tests
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on PR #748
Full chain of PRs as of 2024-06-21
levi/cache-inapp-response-clear-on-logout➔levi/cache-inapp-responses-integration-testslevi/cache-inapp-responses-integration-tests➔levi/cache-inapp-response-test-setuplevi/cache-inapp-response-test-setup➔levi/cache-inapp-responses-at-network-levellevi/cache-inapp-responses-at-network-level➔mainPart of: https://linear.app/customerio/issue/MBL-373/[bug]-in-app-messages-do-not-show-on-ios-if-page-rules-are-enabled-and
When SDK is logged out, clear the in-app network cache to prevent displaying messages to the wrong Journeys profile.
Testing:
Reviewer notes: