-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: device attributes update #640
Conversation
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
@@ -40,12 +37,9 @@ class Context: Plugin { | |||
// set the user agent | |||
context["userAgent"] = userAgentUtil.getUserAgentHeaderValue() | |||
|
|||
// set the device attributes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are not sending CIO device attributes in context, it was providing no value
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main-replica-for-cdp #640 +/- ##
========================================================
- Coverage 57.35% 54.51% -2.84%
========================================================
Files 132 139 +7
Lines 3780 3907 +127
========================================================
- Hits 2168 2130 -38
- Misses 1612 1777 +165 ☔ View full report in Codecov by Sentry. |
@Shahroz16 In tracking migration, we are doing the same i.e. sending the attributes in |
@ami-aman nope, |
Hmm..Device attributes does not only contain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
closes: https://linear.app/customerio/issue/MBL-168/device-attributes-in-journeys
It does the following:
context.device
(it was unnecessary)library
fromcontext
as part of https://linear.app/customerio/issue/MBL-173/remove-library-value