test: ringbuffer for event memory cache #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
ami-aman
reviewed
Jan 5, 2024
| XCTAssertNil(ringBuffer.dequeue(), "Buffer should be empty") | ||
| } | ||
|
|
||
| func test_EnqueueBeyondCapacity_ShouldPushOldestElement() { |
There was a problem hiding this comment.
Suggested change
| func test_EnqueueBeyondCapacity_ShouldPushOldestElement() { | |
| func test_EnqueueBeyondCapacity_ShouldRemoveOldestElement() { |
The method name is messing with my brain. The name provides an impression that it should "push the oldest element" which makes me think that the oldest element should be pushed out as output when dequeued but the method removes the first element and pops out in FIFO order when dequeued. 🤔
ami-aman
approved these changes
Jan 5, 2024
ami-aman
reviewed
Jan 5, 2024
Sources/Common/Util/RingBuffer.swift
Outdated
| @@ -12,6 +12,11 @@ struct RingBuffer<T> { | |||
| // Flag to indicate if the buffer is full. | |||
| private var isFull: Bool = false | |||
|
|
|||
| // Public read-only accessor for isFul | |||
There was a problem hiding this comment.
Suggested change
| // Public read-only accessor for isFul | |
| // Public read-only accessor for isFull |
ami-aman
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken down PR for https://github.com/customerio/customerio-ios/pull/454/files#top
Please go through the details in the parent ticket for further context.