Add Explanation for all the extra attributes #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangvikh
reviewed
Oct 7, 2024
README.md
Outdated
| - ```currency```: What type of Currency | ||
| - ```country```: What Country data is fetched for | ||
| - ```region```: The specific region of prices | ||
| - ```low_price```: If current hour is the lowest of the day |
There was a problem hiding this comment.
I believe this is not true. The value is true if the price is below the low_price threshold set in the config, as a factor of the average price.
There was a problem hiding this comment.
@sangvikh is correct, Can you update please?
sangvikh
reviewed
Nov 11, 2024
Co-authored-by: Harald Sangvik <[email protected]>
sangvikh
approved these changes
Nov 11, 2024
Hellowlol
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added readme for the attributes thats not explained anywhere.