Skip to content
This repository has been archived by the owner on Aug 27, 2022. It is now read-only.

Add Version to Manifest #66

Merged
merged 4 commits into from
Mar 6, 2021
Merged

Add Version to Manifest #66

merged 4 commits into from
Mar 6, 2021

Conversation

GuyKh
Copy link
Contributor

@GuyKh GuyKh commented Mar 4, 2021

Solves Issue #65

@ludeeus
Copy link
Contributor

ludeeus commented Mar 4, 2021

This will require an update of that key for each version, which's not maintainable for me.
Something like https://github.com/hacs/integration/blob/main/.github/workflows/release.yml needs to be added, but I understand that is too much to ask.
I will do that eventually if no one beats me to it.

@ludeeus ludeeus mentioned this pull request Mar 4, 2021
@GuyKh
Copy link
Contributor Author

GuyKh commented Mar 4, 2021

@ludeeus
I took the liberty to beat you to it :)

@ludeeus
Copy link
Contributor

ludeeus commented Mar 6, 2021

@GuyKh
Copy link
Contributor Author

GuyKh commented Mar 6, 2021

@ludeeus
Done.
Now need to try this :)

@ludeeus
Copy link
Contributor

ludeeus commented Mar 6, 2021

I've used that exact file in 2 other repos, so should not be an issue

@ludeeus ludeeus merged commit cf3400f into custom-components:master Mar 6, 2021
@GuyKh GuyKh deleted the version branch March 6, 2021 18:18
@GuyKh
Copy link
Contributor Author

GuyKh commented Mar 6, 2021

Strangely, upon merge, the action didn't run

@ludeeus
Copy link
Contributor

ludeeus commented Mar 6, 2021

It's not supposed to, it's run when a release is released

@ludeeus
Copy link
Contributor

ludeeus commented Mar 6, 2021

@GuyKh
Copy link
Contributor Author

GuyKh commented Mar 6, 2021

Ahhhhh. Good to know!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants