Skip to content
This repository has been archived by the owner on Aug 27, 2022. It is now read-only.

Allow for CIDR notation in IP exclude list #44

Merged
merged 2 commits into from
Jul 26, 2019

Conversation

claytonjn
Copy link
Contributor

This would allow user to exclude their entire local subnet (e.g. - "192.168.1.0/24"). Also, I have a lot of entries from 108.177.70.0/24 and 108.177.71.0/24, which belong to Google and I assume are due to Assistant integration (not using Nabu Casa). CIDR notation is a lot cleaner than adding each of the 510 addresses in those ranges...

This would allow user to exclude their entire local subnet (e.g. - "192.168.1.0/24"). Also, I have a lot of entries from 108.177.70.0/24 and 108.177.71.0/24, which belong to Google and I assume are due to Assistant integration (not using Nabu Casa). CIDR notation is a lot cleaner than adding each of the 510 addresses in those ranges...
@claytonjn
Copy link
Contributor Author

Crap, I thought I tested this thoroughly but I just got a notification that should have been excluded... 🤔

@claytonjn
Copy link
Contributor Author

I think I'm missing something. Can I test the exclude list by deleting .ip_authenticated.yaml, clearing persistent notifications, and rebooting?

@ludeeus
Copy link
Contributor

ludeeus commented Jul 11, 2019

It's actually become a lot smarter in the newer versions, so that will not trigger a new notification.
Only new IP's added to .sorage/auth during runtime are considered new.

reasons:

  • A single IP will never trigger twice.
  • On a new installation, you will not get a notification for all IP's that have previously connected.

@ludeeus ludeeus self-assigned this Jul 11, 2019
@claytonjn
Copy link
Contributor Author

So is the exclusion list not being used in newer versions? I reverted back to the latest release and added a bunch of IPs to the list but still got notifications.

@ludeeus
Copy link
Contributor

ludeeus commented Jul 11, 2019

It should.
That is a bug.

@ludeeus
Copy link
Contributor

ludeeus commented Jul 21, 2019

I have pushed a fix for excluded IP's now, but that completely messed with this PR.
If you still want to add this, please rebase your branch, or open a new PR :)

@claytonjn
Copy link
Contributor Author

Sorry for the delay...I wanted to give it a few days to make sure everything was working. I merged the changes into my branch, but in the diff it's showing the whole file being replaced for some reason. Want me to just open a new PR?

@ludeeus
Copy link
Contributor

ludeeus commented Jul 26, 2019

The reason is the quotes, during the last restructure I enabled auto black formating in the devcontainer, this PR is fine as is

@ludeeus ludeeus merged commit 9256d3e into custom-components:master Jul 26, 2019
@claytonjn claytonjn deleted the patch-1 branch July 26, 2019 17:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants