-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the option for a peristed config volume #87
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
{{- if and .Values.curity.config.persistentConfigVolume.enabled (not .Values.curity.config.persistentConfigVolume.existingClaim) }} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If the new persistentConfigVolume section is completely omitted .enabled setting is not configured in the customer's Helm chart. this seems to create a persistent volume anyway, though I don't understand why. The admin node then has problems. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
kind: PersistentVolumeClaim | ||
apiVersion: v1 | ||
metadata: | ||
name: {{ include "curity.fullname" . }} | ||
labels: | ||
{{- include "curity.labels" . | nindent 4 }} | ||
spec: | ||
storageClassName: {{ .Values.curity.config.persistentConfigVolume.storageClass }} | ||
accessModes: | ||
- {{ .Values.curity.config.persistentConfigVolume.accessMode | quote }} | ||
resources: | ||
requests: | ||
storage: {{ .Values.curity.config.persistentConfigVolume.size | quote }} | ||
{{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would tidy up this comment a little:
Title has a typo:
-Enabling the persistent configuration volume
Then, use persistentVolumeClaim and lower case:
curity.config.persistentConfigVolume.enabled
which will create aPersistentVolumeClaim
using the definedstorageClass
,accessMode
andsize
.