Added the option for a peristed config volume #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gary-archer
reviewed
Oct 30, 2024
| @@ -232,6 +243,17 @@ curity: | |||
| helm upgrade <release-name> curity/idsvr -f myValues.xml | |||
| ``` | |||
|
|
|||
| ## Enabling the peristed configuration volume | |||
|
|
|||
| It is possible to set the `curity.config.persistentConfigVolume.enabled` which will create a `PersistedVolumeClaim` using the defined `StorageClass`, `AccessMode` and `size`. | |||
There was a problem hiding this comment.
I would tidy up this comment a little:
Title has a typo:
-Enabling the persistent configuration volume
Then, use persistentVolumeClaim and lower case:
- It is possible to set the
curity.config.persistentConfigVolume.enabledwhich will create aPersistentVolumeClaimusing the definedstorageClass,accessModeandsize.
gary-archer
reviewed
Oct 30, 2024
| @@ -0,0 +1,15 @@ | |||
| {{- if and .Values.curity.config.persistentConfigVolume.enabled (not .Values.curity.config.persistentConfigVolume.existingClaim) }} | |||
There was a problem hiding this comment.
If the new persistentConfigVolume section is completely omitted .enabled setting is not configured in the customer's Helm chart. this seems to create a persistent volume anyway, though I don't understand why. The admin node then has problems.
There was a problem hiding this comment.
The curity.config.persistendConfigVolume.enabled was true by accident so that's why. I made it default false now.
gary-archer
approved these changes
Nov 11, 2024
suren-khatana
approved these changes
Nov 12, 2024
ambatimuralikrishna
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.