Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync #4

Open
wants to merge 98 commits into
base: upstream-sync-11-12-24
Choose a base branch
from
Open

Conversation

pratikbaid3-curefit
Copy link

No description provided.

focux and others added 30 commits June 10, 2024 17:25
…ions first (#985)

* fix(ios) allow the original delegate to handle non-Notifee notifications first

* chore: update ios simulator to iPhone 15
…manifest for Android 14 compat (#1027)

BREAKING CHANGE: Android 14 no longer allows this by default so no longer include by default. Manually add it if you need it.
a bunch of non-standard formatting has crept in because we're not validating
required for new foreground service symbols, which are required for Android 14 compatibility
BREAKING CHANGE: foreground service users must manually add Android permissions for Android 14+

requires android compileSdk of 34 or greater for new symbols to be available

Android 14+ require foreground services to be strongly typed with specific permissions requested
in the AndroidManifest and specified by the application. You are required to add the correct
permission for the type of service you are using, and then declare it + justify the usage in
the Google Play Store if you need foreground services
the npm publish process itself dirties the repo, so you need to npm publish
first then commit + tag + push on git then create the release
…nceDestroy

invalidate is the new way to have a hook called when react-native instances are going away, but onCatalystInstanceDestroy is still required for compatibility with older react-native versions
9.0.1 was not updated locally from remote so did not actually contain
the fix, sigh
should eliminate timeout flakiness
on iOS16+ etc there are new badging APIs and to correctly set icon
to zero on these devices you cannot use the old-api + set to -1 trick

it apparently still leaves the notification center notifications intact
though, which is nice
without this no caching was happening
Ehesp and others added 30 commits December 17, 2024 12:10
… spot

this gets our release notes in the docs.page future up to date and set to
auto-update going forward
these were tiny edits on old docs while docs.page PR was waiting on merge

from commits:
- a48abc1
- f13c5e6
- workflow path exclusions
- gitattributes etc
- CONTRIBUTING information
- typedoc generation
so focused on semantic release publish workflow yesterday (which was
set to use `lts/*` as node spec) that I didn't realize pulling
semantic-release dep in bumped minimum acceptable node to 20 and
we were on 18 in most workflows
we will likely get the notifee.app custom url pointed there again
shortly, but let's have live links in the meantime
…lease

these are altered on release and if we want to have reproducible builds or at least
have all the things we actually published also committed to source control we need
to commit these as well
this matches my typical development environment more closely, so if
it works locally (it does...) it should work in CI as well
there was the possibility on certain OSes (Ubuntu-22 it seems) that
bash would copy into sub-directories with casual usage of paths

now the copy is definitely to an absolute path and won't create erroneous
nested directories regardless of initial state

also it will print what it's copying, for later verification
## [9.1.7](https://github.com/invertase/notifee/compare/@notifee/[email protected]...@notifee/[email protected]) (2024-12-17)

### Bug Fixes

* **ios:** copy iOS NotifeeCore library more carefully during build ([68f230f](68f230f))
- use mdx file extension since that's what docs.page expects
- use flat output so relative links don't have pathing issues on docs.page
- use main branch vs git revision in source links
- set entry file name to `index`
- add custom `@platform` typedoc comment
- bend generated internal links to match docs.page URL auto-linking path components
 - strip .mdx from end of URL path
 - add prefix path components
this should keep the API reference in sync with published releases
without having to remember to generate it manually
these were silently passing in older typescript but newer typescript is
better at finding incorrect things
it was possible if multiple tasks came in at once while react-native
headlessJS was performing initial react-native startup for the queued
events to be invoked multiple times once startup finished

this is protected via a couple mechanisms now
this makes sure they are in the release git commit, which is prepared
before the prepublishOnly task generates these things otherwise
note this did not trigger the ObjectAlreadyConsumedException, which
is a shame, but it does stress the headlessJS system a bit so it
seems worth keeping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.