forked from invertase/notifee
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync #4
Open
pratikbaid3-curefit
wants to merge
98
commits into
curefit:upstream-sync-11-12-24
Choose a base branch
from
invertase:main
base: upstream-sync-11-12-24
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sync #4
pratikbaid3-curefit
wants to merge
98
commits into
curefit:upstream-sync-11-12-24
from
invertase:main
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions first (#985) * fix(ios) allow the original delegate to handle non-Notifee notifications first * chore: update ios simulator to iPhone 15
…manifest for Android 14 compat (#1027) BREAKING CHANGE: Android 14 no longer allows this by default so no longer include by default. Manually add it if you need it.
… if needed doc change related to #1054
a bunch of non-standard formatting has crept in because we're not validating
required for new foreground service symbols, which are required for Android 14 compatibility
BREAKING CHANGE: foreground service users must manually add Android permissions for Android 14+ requires android compileSdk of 34 or greater for new symbols to be available Android 14+ require foreground services to be strongly typed with specific permissions requested in the AndroidManifest and specified by the application. You are required to add the correct permission for the type of service you are using, and then declare it + justify the usage in the Google Play Store if you need foreground services
Android 15 adds a new foreground service type, it should be valid to use it in case people want to https://developer.android.com/about/versions/15/behavior-changes-15#mediaprocessing-fgs-type
the npm publish process itself dirties the repo, so you need to npm publish first then commit + tag + push on git then create the release
v8 was skipped
…nceDestroy invalidate is the new way to have a hook called when react-native instances are going away, but onCatalystInstanceDestroy is still required for compatibility with older react-native versions
9.0.1 was not updated locally from remote so did not actually contain the fix, sigh
should eliminate timeout flakiness
on iOS16+ etc there are new badging APIs and to correctly set icon to zero on these devices you cannot use the old-api + set to -1 trick it apparently still leaves the notification center notifications intact though, which is nice
without this no caching was happening
… spot this gets our release notes in the docs.page future up to date and set to auto-update going forward
- workflow path exclusions - gitattributes etc - CONTRIBUTING information - typedoc generation
so focused on semantic release publish workflow yesterday (which was set to use `lts/*` as node spec) that I didn't realize pulling semantic-release dep in bumped minimum acceptable node to 20 and we were on 18 in most workflows
we will likely get the notifee.app custom url pointed there again shortly, but let's have live links in the meantime
…lease these are altered on release and if we want to have reproducible builds or at least have all the things we actually published also committed to source control we need to commit these as well
this matches my typical development environment more closely, so if it works locally (it does...) it should work in CI as well
there was the possibility on certain OSes (Ubuntu-22 it seems) that bash would copy into sub-directories with casual usage of paths now the copy is definitely to an absolute path and won't create erroneous nested directories regardless of initial state also it will print what it's copying, for later verification
## [9.1.7](https://github.com/invertase/notifee/compare/@notifee/[email protected]...@notifee/[email protected]) (2024-12-17) ### Bug Fixes * **ios:** copy iOS NotifeeCore library more carefully during build ([68f230f](68f230f))
- use mdx file extension since that's what docs.page expects - use flat output so relative links don't have pathing issues on docs.page - use main branch vs git revision in source links - set entry file name to `index` - add custom `@platform` typedoc comment - bend generated internal links to match docs.page URL auto-linking path components - strip .mdx from end of URL path - add prefix path components
this should keep the API reference in sync with published releases without having to remember to generate it manually
these were silently passing in older typescript but newer typescript is better at finding incorrect things
it was possible if multiple tasks came in at once while react-native headlessJS was performing initial react-native startup for the queued events to be invoked multiple times once startup finished this is protected via a couple mechanisms now
## [9.1.8](https://github.com/invertase/notifee/compare/@notifee/[email protected]...@notifee/[email protected]) (2024-12-20) ### Bug Fixes * **android:** prevent headless task double-invocation ([a799167](a799167))
this makes sure they are in the release git commit, which is prepared before the prepublishOnly task generates these things otherwise
note this did not trigger the ObjectAlreadyConsumedException, which is a shame, but it does stress the headlessJS system a bit so it seems worth keeping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.