-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components | Header design update #125
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/curaos/frontend/BTYMPJ3KEdoe27DAf2ifE3E6iLhB |
Something went wrong with Chromatic and importing logo. I have to check that first |
working now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @achrafismyname. A couple of adjustments. The rest seems fine. We'll just do minor adjustments when the pages come together later on.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
🎉 This PR is included in version @cura/components-v1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Live view
Theme.ts
Edited previous variants as needed
Added
layout.container
that should used on components that have a fluid widthAdded
link.navigation
variants which is going to be used in the Menu components next,Added
borders
variants, so we have all borders in one placebackgroundImg
, so we can change logo directly from theme.ts. Infrontend/theme.ts
, the logo is a direct url from the public folder, but incomponents/theme.ts
, the logo is imported as a static file.Header Component
Userbutton
which is changed depending on user authentication and hover/
so we can style each part differently like the design and it doesn't affect titles that doesn't have/
.