Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components | Header design update #125

Merged
merged 5 commits into from
Nov 22, 2021
Merged

Conversation

sekaiking
Copy link
Contributor

@sekaiking sekaiking commented Nov 15, 2021

Live view

Theme.ts

  • Edited previous variants as needed

  • Added layout.container that should used on components that have a fluid width

  • Added link.navigation variants which is going to be used in the Menu components next,

  • Added borders variants, so we have all borders in one place

From my testing theme-ui doesn't read color variants inside border, so this is the solution I did

  borders: {
      0: 0,
      1: `1px solid ${colors.colors.text}`,
  },
  • Added the logo as an image variant using backgroundImg, so we can change logo directly from theme.ts. In frontend/theme.ts, the logo is a direct url from the public folder, but in components/theme.ts, the logo is imported as a static file.

I'm not sure if that was the best approach, if you have any better idea on how to improve it let me know.

Header Component

  • Added a sub component for Userbutton which is changed depending on user authentication and hover
  • Title is being split now by / so we can style each part differently like the design and it doesn't affect titles that doesn't have /.
  • Changed links in the header like the following:
    • Logo -> home
    • Title -> user bids
    • UserButton -> connect/disconnect

@vercel
Copy link

vercel bot commented Nov 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/curaos/frontend/BTYMPJ3KEdoe27DAf2ifE3E6iLhB
✅ Preview: https://frontend-git-headerdesignupdate-curaos.vercel.app

@sekaiking sekaiking marked this pull request as draft November 15, 2021 14:01
@sekaiking
Copy link
Contributor Author

Something went wrong with Chromatic and importing logo. I have to check that first

@sekaiking
Copy link
Contributor Author

Something went wrong with Chromatic and importing logo. I have to check that first

working now :)

@sekaiking sekaiking linked an issue Nov 15, 2021 that may be closed by this pull request
Copy link
Collaborator

@bestatigen bestatigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @achrafismyname. A couple of adjustments. The rest seems fine. We'll just do minor adjustments when the pages come together later on.

Thanks!

examples/frontend/public/logo.svg Show resolved Hide resolved
packages/components/src/Header.tsx Show resolved Hide resolved
packages/components/src/Header.tsx Show resolved Hide resolved
@sekaiking
Copy link
Contributor Author

@bestatigen bestatigen changed the title Components: Header design update Components | Header design update Nov 22, 2021
Copy link
Collaborator

@bestatigen bestatigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bestatigen bestatigen mentioned this pull request Nov 22, 2021
@sekaiking sekaiking merged commit 95b3d9a into design_update Nov 22, 2021
@sekaiking sekaiking deleted the header_design_update branch November 22, 2021 15:52
@github-actions
Copy link

🎉 This PR is included in version @cura/components-v1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update Header design
2 participants