Merge pull request sbt#333 from ashawley/gen-pick-defect

Gen.pick defect
cunei · Jul 13, 2017 · db2a1fc · db2a1fc
2 parents 3f7ef62 + 2ee295d
commit db2a1fc
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/jvm/src/test/scala/org/scalacheck/GenSpecification.scala b/jvm/src/test/scala/org/scalacheck/GenSpecification.scala
@@ -200,6 +200,18 @@ object GenSpecification extends Properties("Gen") {
     }
   }
 
+  property("distributed pick") = {
+    val lst = (0 to 7).toIterable
+    val n = 2
+    forAll(pick(n, lst)) { xs: Seq[Int] =>
+      xs.map { x: Int =>
+        Prop.collect(x) {
+          xs.size == n
+        }
+      } reduce (_ && _)
+    }
+  }
+
   property("numChar") = forAll(numChar)(_.isDigit)
 
   property("calendar") = forAll(calendar) { cal =>

diff --git a/src/main/scala/org/scalacheck/Gen.scala b/src/main/scala/org/scalacheck/Gen.scala
@@ -681,7 +681,7 @@ object Gen extends GenArities{
           buf += t
         } else {
           val (x, s) = seed.long
-          val i = (x & 0x7fffffff).toInt % n
+          val i = (x & 0x7fffffff).toInt % count
           if (i < n) buf(i) = t
           seed = s
         }